From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US813-0003wj-Or for qemu-devel@nongnu.org; Tue, 16 Apr 2013 11:41:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1US812-00061b-Fj for qemu-devel@nongnu.org; Tue, 16 Apr 2013 11:41:53 -0400 Received: from mail-qa0-f54.google.com ([209.85.216.54]:34778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1US812-000618-CF for qemu-devel@nongnu.org; Tue, 16 Apr 2013 11:41:52 -0400 Received: by mail-qa0-f54.google.com with SMTP id j8so356370qah.13 for ; Tue, 16 Apr 2013 08:41:51 -0700 (PDT) From: Anthony Liguori In-Reply-To: <515BE38E.8050505@redhat.com> References: <1364402192-18169-1-git-send-email-pbonzini@redhat.com> <515BE38E.8050505@redhat.com> Date: Tue, 16 Apr 2013 10:41:47 -0500 Message-ID: <87zjwyo538.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/6] migration: followups for writev patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman , Paolo Bonzini Cc: qemu-devel@nongnu.org, quintela@redhat.com Orit Wasserman writes: > On 03/27/2013 06:36 PM, Paolo Bonzini wrote: >> This series fixes a few small problems in Orit's writev patches: >> >> 1) socket_put_buffer is not needed anymore and can be dropped (patch 1); >> >> 2) sendmsg could do a partial write even for a blocking socket, in >> case it is interrupted by a signal. This should not happen for >> migration, but it is relatively easy to fix in iov_send_recv (patches >> 2 to 5); >> >> 3) recent libvirt will always use fd migration, and thus will not >> benefit from the writev speedups. fd migration also uses FILE*, which >> incurs an extra copy. Patch 6 fixes both issues. >> >> Thanks, >> >> Paolo >> >> Paolo Bonzini (6): >> qemu-file: drop socket_put_buffer >> iov: reorganize iov_send_recv, part 1 >> iov: reorganize iov_send_recv, part 2 >> iov: reorganize iov_send_recv, part 3 >> iov: handle partial writes from sendmsg and recvmsg >> qemu-file: do not use stdio for qemu_fdopen >> >> savevm.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++++------------- >> util/iov.c | 104 ++++++++++++++++++++++++++++++++------------------------ >> 2 files changed, 148 insertions(+), 69 deletions(-) >> > Series > Reviewed-by: Orit Wasserman Per Paolo, I will process this through my queue. Regards, Anthony Liguori