qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pty: unbreak libvirt
Date: Thu, 03 Jan 2013 13:44:01 -0600	[thread overview]
Message-ID: <87zk0q2gse.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA9z=3it42pJ_Ukq4T6MOgLCzrkpRYFjiWVCFHh+RLiKVA@mail.gmail.com>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 3 January 2013 19:00, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> Thanks, applied.
>
> So we now say "char device redirected to /dev/pts/5 (compat_monitor0)"
> rather than "char device compat_monitor0 redirected to /dev/pts/5" ?
> I think that's a reduction in clarity and it's sad that we have to do it.
>
> I also think that everywhere we have something with a specific
> format which we're retaining for the benefit of libvirt we should
> have big warning comments saying "Do not change this because
> libvirt versions older than X.Y depend upon the exact text".
> Otherwise we'll just trip over the same bugs again later.

I don't intend that we keep this forever.   But it's hardly compelling
to do it one way vs. the other so compatibility wins.

Regards,

Anthony Liguori

>
> -- PMM

      reply	other threads:[~2013-01-03 19:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 13:23 [Qemu-devel] [PATCH] pty: unbreak libvirt Gerd Hoffmann
2013-01-03 13:33 ` Daniel P. Berrange
2013-01-03 18:55   ` Anthony Liguori
2013-01-03 19:00 ` Anthony Liguori
2013-01-03 19:10   ` Peter Maydell
2013-01-03 19:44     ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk0q2gse.fsf@codemonkey.ws \
    --to=aliguori@us.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).