From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqqiF-0001Ma-MP for qemu-devel@nongnu.org; Thu, 03 Jan 2013 14:44:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqqiE-0005am-6h for qemu-devel@nongnu.org; Thu, 03 Jan 2013 14:44:23 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:45406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqqiD-0005af-WF for qemu-devel@nongnu.org; Thu, 03 Jan 2013 14:44:22 -0500 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Jan 2013 12:44:21 -0700 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 77F823E40039 for ; Thu, 3 Jan 2013 12:44:13 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r03Ji89O237278 for ; Thu, 3 Jan 2013 12:44:12 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r03Ji5XR026614 for ; Thu, 3 Jan 2013 12:44:08 -0700 From: Anthony Liguori In-Reply-To: References: <1357219383-30748-1-git-send-email-kraxel@redhat.com> <201301031900.r03J0Ukb002306@d01av03.pok.ibm.com> Date: Thu, 03 Jan 2013 13:44:01 -0600 Message-ID: <87zk0q2gse.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] pty: unbreak libvirt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Gerd Hoffmann , qemu-devel@nongnu.org Peter Maydell writes: > On 3 January 2013 19:00, Anthony Liguori wrote: >> Thanks, applied. > > So we now say "char device redirected to /dev/pts/5 (compat_monitor0)" > rather than "char device compat_monitor0 redirected to /dev/pts/5" ? > I think that's a reduction in clarity and it's sad that we have to do it. > > I also think that everywhere we have something with a specific > format which we're retaining for the benefit of libvirt we should > have big warning comments saying "Do not change this because > libvirt versions older than X.Y depend upon the exact text". > Otherwise we'll just trip over the same bugs again later. I don't intend that we keep this forever. But it's hardly compelling to do it one way vs. the other so compatibility wins. Regards, Anthony Liguori > > -- PMM