From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal
Date: Tue, 20 Nov 2012 19:41:22 -0600 [thread overview]
Message-ID: <87zk2bka0t.fsf@codemonkey.ws> (raw)
In-Reply-To: <4174418d72ef8966c94434a814c2a67d5d33f646.1353421334.git.amit.shah@redhat.com>
Amit Shah <amit.shah@redhat.com> writes:
> Disable the rate-limit timer on device remove (e.g. hot-unplug).
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
Nice catch.
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
> ---
> hw/virtio-rng.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
> index cf5a8ff..c8a6da7 100644
> --- a/hw/virtio-rng.c
> +++ b/hw/virtio-rng.c
> @@ -194,6 +194,8 @@ void virtio_rng_exit(VirtIODevice *vdev)
> {
> VirtIORNG *vrng = DO_UPCAST(VirtIORNG, vdev, vdev);
>
> + qemu_del_timer(vrng->rate_limit_timer);
> + qemu_free_timer(vrng->rate_limit_timer);
> unregister_savevm(vrng->qdev, "virtio-rng", vrng);
> virtio_cleanup(vdev);
> }
> --
> 1.8.0
next prev parent reply other threads:[~2012-11-21 1:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 14:26 [Qemu-devel] [PATCH 0/4] [For 0.13] virtio-rng: Fixes Amit Shah
2012-11-20 14:26 ` [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration Amit Shah
2012-11-21 1:44 ` Anthony Liguori
2012-11-21 5:53 ` Amit Shah
2012-11-20 14:26 ` [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy Amit Shah
2012-11-21 1:41 ` Anthony Liguori
2012-11-20 14:26 ` [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal Amit Shah
2012-11-21 1:41 ` Anthony Liguori [this message]
2012-11-20 14:26 ` [Qemu-devel] [PATCH 4/4] virtio-rng: fix typos, comments Amit Shah
2012-11-21 1:43 ` Anthony Liguori
2012-11-21 5:51 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk2bka0t.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=amit.shah@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).