From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRpwE-0007e8-6u for qemu-devel@nongnu.org; Fri, 26 Oct 2012 15:51:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRpwD-0007Az-4z for qemu-devel@nongnu.org; Fri, 26 Oct 2012 15:51:26 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:40642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRpwC-0007Ag-Ez for qemu-devel@nongnu.org; Fri, 26 Oct 2012 15:51:25 -0400 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 27 Oct 2012 01:21:16 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9QJpDOB1704250 for ; Sat, 27 Oct 2012 01:21:13 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9R1L4vQ013598 for ; Sat, 27 Oct 2012 12:21:04 +1100 From: Anthony Liguori In-Reply-To: <508ADDAA.7070205@redhat.com> References: <1351272088-7942-1-git-send-email-aliguori@us.ibm.com> <1351272088-7942-3-git-send-email-aliguori@us.ibm.com> <508ADDAA.7070205@redhat.com> Date: Fri, 26 Oct 2012 14:51:05 -0500 Message-ID: <87zk39ypue.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-rng-pci: create a default backend if none exists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Amit Shah , qemu-devel@nongnu.org, Andreas Faerber Paolo Bonzini writes: > Il 26/10/2012 19:21, Anthony Liguori ha scritto: >> This allows you to specify: >> >> $ qemu -device virtio-rng-pci >> >> And things will Just Work with a reasonable default. >> >> Signed-off-by: Anthony Liguori >> --- >> hw/virtio-pci.c | 13 +++++++++++++ >> hw/virtio-rng.h | 2 ++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c >> index 0dc2a06..cfdb779 100644 >> --- a/hw/virtio-pci.c >> +++ b/hw/virtio-pci.c >> @@ -885,6 +885,19 @@ static int virtio_rng_init_pci(PCIDevice *pci_dev) >> VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev); >> VirtIODevice *vdev; >> >> + if (proxy->rng.rng == NULL) { >> + proxy->rng.default_backend = RNG_RANDOM(object_new(TYPE_RNG_RANDOM)); >> + >> + object_property_add_child(OBJECT(pci_dev), >> + "default-backend", >> + OBJECT(proxy->rng.default_backend), >> + NULL); >> + >> + object_property_set_link(OBJECT(pci_dev), >> + OBJECT(proxy->rng.default_backend), >> + "rng", NULL); >> + } >> + >> vdev = virtio_rng_init(&pci_dev->qdev, &proxy->rng); >> if (!vdev) { >> return -1; >> diff --git a/hw/virtio-rng.h b/hw/virtio-rng.h >> index fbb0104..63ddb96 100644 >> --- a/hw/virtio-rng.h >> +++ b/hw/virtio-rng.h >> @@ -13,12 +13,14 @@ >> #define _QEMU_VIRTIO_RNG_H >> >> #include "qemu/rng.h" >> +#include "qemu/rng-random.h" >> >> /* The Virtio ID for the virtio rng device */ >> #define VIRTIO_ID_RNG 4 >> >> struct VirtIORNGConf { >> RngBackend *rng; >> + RndRandom *default_backend; >> }; >> >> #endif >> > > NACK. Starting a guest that runs rngd (or just a malicious guest) will > completely deprive the host of entropy. That's why this is a separate series... Still don't understand what the default entropy source should be. > If you make the default /dev/hwrng, however, that would be ok. /dev/hwrng may be (and stay) empty which seems unfortunate. I was thinking /dev/urandom would be a good pragmatic choice though. Regards, Anthony Liguori > > Paolo