From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwbAG-0002Je-Qn for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:48:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwbAF-0004Hz-TY for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:48:48 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:51552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwbAF-0004Hr-P9 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:48:47 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Aug 2012 11:48:47 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id CA278C90B94 for ; Wed, 1 Aug 2012 11:43:43 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q71FhgXV118878 for ; Wed, 1 Aug 2012 11:43:42 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q71FhHek002630 for ; Wed, 1 Aug 2012 12:43:17 -0300 From: Anthony Liguori In-Reply-To: <1343049748-11539-1-git-send-email-imammedo@redhat.com> References: <1343049748-11539-1-git-send-email-imammedo@redhat.com> Date: Wed, 01 Aug 2012 10:43:11 -0500 Message-ID: <87zk6elisw.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, ehabkost@redhat.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, afaerber@suse.de Igor Mammedov writes: > v2: > ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu(), > to keep cpu_init implementation in -softmmu and -user targets the same > in single place and maintanable. > > v3: > reuse cpu_is_bsp() rather than open code check if apicbase has BSP bit set > > tree for testing: > https://github.com/imammedo/qemu/tree/x86_reset_v3 > > comiple & run tested with x86_64-linux-user, x86_64-softmmu targets > > Igor Mammedov (2): > target-i386: move cpu halted decision into x86_cpu_reset > target-i386: move cpu_reset and reset callback to cpu.c Applied all. Thanks. Regards, Anthony Liguori > > hw/apic.h | 5 ++++- > hw/apic_common.c | 16 +++++++++++++--- > hw/pc.c | 18 +----------------- > target-i386/cpu.c | 30 ++++++++++++++++++++++++++++++ > target-i386/helper.c | 1 - > target-i386/kvm.c | 4 +++- > 6 files changed, 51 insertions(+), 23 deletions(-)