From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B5DC433F5 for ; Tue, 19 Oct 2021 09:51:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8418F61057 for ; Tue, 19 Oct 2021 09:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8418F61057 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcllr-00041a-KV for qemu-devel@archiver.kernel.org; Tue, 19 Oct 2021 05:50:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcljX-0000SX-EO; Tue, 19 Oct 2021 05:48:36 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:54409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcljU-0006YI-J2; Tue, 19 Oct 2021 05:48:35 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4HYTT90j3cz9sSR; Tue, 19 Oct 2021 11:48:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PuodwBqRlQby; Tue, 19 Oct 2021 11:48:29 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4HYTT86kCZz9sSP; Tue, 19 Oct 2021 11:48:28 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id CF9428B778; Tue, 19 Oct 2021 11:48:28 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 66TumUHC2Q-h; Tue, 19 Oct 2021 11:48:28 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (unknown [192.168.203.83]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B7BA28B763; Tue, 19 Oct 2021 11:48:27 +0200 (CEST) Subject: Re: Deprecate the ppc405 boards in QEMU? To: Thomas Huth References: <0beb4744-5421-2cec-1fe4-6a8b7353d932@redhat.com> <3b1570d3-56f5-1184-239a-72791fc8ef83@redhat.com> <881242de-fec8-3296-ffb4-36d2a551d21f@redhat.com> <119bc1c7-22e0-c455-9f34-57a7424f0c52@redhat.com> <7526ae07-0054-69df-c71f-8751858ef0db@redhat.com> <8c382ce4-f706-376c-289a-b8c64393decb@redhat.com> From: Christophe Leroy Message-ID: <880f4bde-19fc-1267-3a04-3d9efd660897@csgroup.eu> Date: Tue, 19 Oct 2021 11:48:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <8c382ce4-f706-376c-289a-b8c64393decb@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr-FR Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=93.17.235.10; envelope-from=christophe.leroy@csgroup.eu; helo=pegase2.c-s.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , dbarboza@redhat.com, Alexey Kardashevskiy , Greg Kurz , Wainer dos Santos Moschetta , QEMU Developers , Alexander Graf , qemu-ppc , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Cleber Rosa , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 19/10/2021 à 11:39, Thomas Huth a écrit : > On 19/10/2021 11.31, Christophe Leroy wrote: >> >> >> Le 11/10/2021 à 15:24, Thomas Huth a écrit : >>> On 11/10/2021 11.20, David Gibson wrote: >>>> On Mon, Oct 11, 2021 at 10:10:36AM +0200, Thomas Huth wrote: >>>>> On 06/10/2021 09.25, Thomas Huth wrote: >>>>>> On 05/10/2021 23.53, BALATON Zoltan wrote: >>>>>> [...] >>>>>>> Maybe these 405 boards in QEMU ran with modified firmware where the >>>>>>> memory detection was patched out but it seems to detect the RAM so I >>>>>>> wonder where it gets that from. Maybe by reading the SDRAM >>>>>>> controller DCRs ppc4xx_sdram_init() sets up. Then I'm not sure what >>>>>>> it needs the SPD for, I forgot how this worked on sam460ex. Maybe >>>>>>> for the speed calibration, so could be it detects ram by reading >>>>>>> DCRs then tries to get SPD data and that's where it stops as i2c is >>>>>>> not emulated on taihu. This could be confirmed by checking what it >>>>>>> pokes with -d guest_errors that shows accesses to missing devices >>>>>>> but don't know where 405 has the i2c controller and if it's the same >>>>>>> as newer SoCs. If so that could be reused and an i2c bus could be >>>>>>> added with the SPD data like in sam460ex to make u-boot happy or you >>>>>>> could skip this in u-boot. >>>>>> >>>>>> FWIW, I've just tried the latter (skipping the sdram init in u-boot), >>>>>> and indeed, I can get to the u-boot prompt now. >>>>> [...]> I've also attached the patch with my modifications to u-boot. >>>>> >>>>> FYI, the changes can now be found on this branch here: >>>>> >>>>>   https://gitlab.com/huth/u-boot/-/commits/taihu >>>>> >>>>> I also added a gitlab-CI file, so you can now download the >>>>> u-boot.bin as an >>>>> artifact from the corresponding pipeline, e.g.: >>>>> >>>>>   https://gitlab.com/huth/u-boot/-/jobs/1667201028 >>>> >>>> Thanks. >>>> >>>> Are you going to send a v2 of your proposed deprecation patches? >>> >>> No, since there was interest in keeping the 405 boards for testing >>> the 405 code in the Linux kernel, and since there is now a way to do >>> at least some very basic testing of these boards (with the u-boot >>> firmware), I don't plan to respin the deprecation patch. I just sent >>> a patch for adding the boards to our CI instead: >>> >>>   https://lists.gnu.org/archive/html/qemu-devel/2021-10/msg02072.html >>> >> >> I have downloaded your u-boot.bin and tried it with both QEMU 5.2.0 >> and mainline, and I get: >> >> ERROR:../accel/tcg/tcg-accel-ops.c:79:tcg_handle_interrupt: assertion >> failed: (qemu_mutex_iothread_locked()) >> Bail out! ERROR:../accel/tcg/tcg-accel-ops.c:79:tcg_handle_interrupt: >> assertion failed: (qemu_mutex_iothread_locked()) >> Abandon (core dumped) >> >> I see in the mail history that you got that problem as well at some >> point. How did you fix it ? > > You need this patch here to fix this issue: > >  https://lists.gnu.org/archive/html/qemu-devel/2021-10/msg01019.html >  ("hw/ppc: Fix iothread locking in the 405 code") > Thank you. Is there anything special to do then in order to boot a Linux kernel ? I build the uImage for ppc40x_defconfig I use the following command, but it does nothing, it stays in uboot prompt as when I don't get a kernel argument ~/qemu/build/qemu-system-ppc -M taihu -bios ~/Téléchargements/u-boot.bin -serial null -serial mon:stdio -kernel arch/powerpc/boot/uImage Thanks Christophe