From: Claudio Fontana <cfontana@suse.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
kvm@vger.kernel.org, Paul Burton <paulburton@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [RFC PATCH 18/19] target/mips: Restrict some TCG specific CPUClass handlers
Date: Mon, 7 Dec 2020 08:59:57 +0100 [thread overview]
Message-ID: <88161f99-aae5-3b80-e8c6-a57d122a28c4@suse.de> (raw)
In-Reply-To: <20201206233949.3783184-19-f4bug@amsat.org>
On 12/7/20 12:39 AM, Philippe Mathieu-Daudé wrote:
> Restrict the following CPUClass handlers to TCG:
> - do_interrupt
In this patch it seems do_interrupt is changed to be CONFIG_USER_ONLY, it is not restricted to TCG.
Was this desired, should be commented as such?
Also, should the whole function then be #ifdefed out in helpers.c?
I guess I am vouching for moving the ifndef CONFIG_USER_ONLY one line up in helpers.c.
But you wanted this CONFIG_TCG-only?
> - do_transaction_failed
> - do_unaligned_access
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Cc: Claudio Fontana <cfontana@suse.de>
>
> target/mips/cpu.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/target/mips/cpu.c b/target/mips/cpu.c
> index 8a4486e3ea1..03bd35b7903 100644
> --- a/target/mips/cpu.c
> +++ b/target/mips/cpu.c
> @@ -483,7 +483,6 @@ static void mips_cpu_class_init(ObjectClass *c, void *data)
>
> cc->class_by_name = mips_cpu_class_by_name;
> cc->has_work = mips_cpu_has_work;
> - cc->do_interrupt = mips_cpu_do_interrupt;
> cc->cpu_exec_interrupt = mips_cpu_exec_interrupt;
> cc->dump_state = mips_cpu_dump_state;
> cc->set_pc = mips_cpu_set_pc;
> @@ -491,8 +490,7 @@ static void mips_cpu_class_init(ObjectClass *c, void *data)
> cc->gdb_read_register = mips_cpu_gdb_read_register;
> cc->gdb_write_register = mips_cpu_gdb_write_register;
> #ifndef CONFIG_USER_ONLY
> - cc->do_transaction_failed = mips_cpu_do_transaction_failed;
> - cc->do_unaligned_access = mips_cpu_do_unaligned_access;
> + cc->do_interrupt = mips_cpu_do_interrupt;
> cc->get_phys_page_debug = mips_cpu_get_phys_page_debug;
> cc->vmsd = &vmstate_mips_cpu;
> #endif
> @@ -500,6 +498,10 @@ static void mips_cpu_class_init(ObjectClass *c, void *data)
> #ifdef CONFIG_TCG
> cc->tcg_initialize = mips_tcg_init;
> cc->tlb_fill = mips_cpu_tlb_fill;
> +#if !defined(CONFIG_USER_ONLY)
> + cc->do_unaligned_access = mips_cpu_do_unaligned_access;
> + cc->do_transaction_failed = mips_cpu_do_transaction_failed;
> +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */
> #endif
>
> cc->gdb_num_core_regs = 73;
>
next prev parent reply other threads:[~2020-12-07 8:18 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 23:39 [PATCH 00/19] target/mips: Boring code reordering Philippe Mathieu-Daudé
2020-12-06 23:39 ` [PATCH 01/19] hw/mips: Move address translation helpers to target/mips/ Philippe Mathieu-Daudé
2020-12-08 21:46 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 02/19] target/mips: Remove unused headers from translate.c Philippe Mathieu-Daudé
2020-12-08 21:47 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 03/19] target/mips: Remove unused headers from fpu_helper.c Philippe Mathieu-Daudé
2020-12-08 21:49 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 04/19] target/mips: Remove unused headers from cp0_helper.c Philippe Mathieu-Daudé
2020-12-08 21:50 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 05/19] target/mips: Remove unused headers from op_helper.c Philippe Mathieu-Daudé
2020-12-08 21:50 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 06/19] target/mips: Remove unused headers from kvm.c Philippe Mathieu-Daudé
2020-12-08 21:50 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 07/19] target/mips: Include "exec/memattrs.h" in 'internal.h' Philippe Mathieu-Daudé
2020-12-08 21:51 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 08/19] target/mips: Extract cpu_supports*/cpu_set* translate.c Philippe Mathieu-Daudé
2020-12-08 21:53 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 09/19] target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c Philippe Mathieu-Daudé
2020-12-08 21:55 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 10/19] target/mips: Add !CONFIG_USER_ONLY comment after #endif Philippe Mathieu-Daudé
2020-12-08 21:59 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 11/19] target/mips: Extract common helpers from helper.c to common_helper.c Philippe Mathieu-Daudé
2020-12-08 22:06 ` Richard Henderson
2020-12-14 14:23 ` Philippe Mathieu-Daudé
2020-12-14 14:51 ` 罗勇刚(Yonggang Luo)
2020-12-14 14:54 ` Philippe Mathieu-Daudé
2020-12-06 23:39 ` [PATCH 12/19] target/mips: Rename helper.c as tlb_helper.c Philippe Mathieu-Daudé
2020-12-08 22:09 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 13/19] target/mips: Fix code style for checkpatch.pl Philippe Mathieu-Daudé
2020-12-08 22:11 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 14/19] target/mips: Move mmu_init() functions to tlb_helper.c Philippe Mathieu-Daudé
2020-12-08 22:19 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 15/19] target/mips: Move cpu definitions, reset() and realize() to cpu.c Philippe Mathieu-Daudé
2020-12-08 22:27 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 16/19] target/mips: Inline cpu_mips_realize_env() in mips_cpu_realizefn() Philippe Mathieu-Daudé
2020-12-08 22:27 ` Richard Henderson
2020-12-06 23:39 ` [PATCH 17/19] target/mips: Rename translate_init.c as cpu-defs.c Philippe Mathieu-Daudé
2020-12-08 22:30 ` Richard Henderson
2020-12-14 14:40 ` Philippe Mathieu-Daudé
2020-12-06 23:39 ` [RFC PATCH 18/19] target/mips: Restrict some TCG specific CPUClass handlers Philippe Mathieu-Daudé
2020-12-07 7:59 ` Claudio Fontana [this message]
2020-12-07 8:53 ` Claudio Fontana
2020-12-07 9:07 ` Claudio Fontana
2020-12-07 11:43 ` Claudio Fontana
2020-12-07 12:49 ` Philippe Mathieu-Daudé
2020-12-06 23:39 ` [RFC PATCH 19/19] target/mips: Only build TCG code when CONFIG_TCG is set Philippe Mathieu-Daudé
2020-12-08 22:30 ` Richard Henderson
2020-12-06 23:45 ` [PATCH 00/19] target/mips: Boring code reordering no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88161f99-aae5-3b80-e8c6-a57d122a28c4@suse.de \
--to=cfontana@suse.de \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).