qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH] tests/qtest/meson.build: Add more CONFIG switches checks for the x86 tests
Date: Thu, 5 Sep 2024 12:52:23 +0200	[thread overview]
Message-ID: <881fcbd7-d78f-4b42-b1e7-f4321cc9dc2a@redhat.com> (raw)
In-Reply-To: <37254a58-3f76-4c12-a2ae-0f2259e8bf9f@redhat.com>

On 05/09/2024 10.28, Paolo Bonzini wrote:
> On 9/4/24 10:21, Thomas Huth wrote:
>> When configuring QEMU with "--without-default-devices", currently a lot
>> of the x86 qtests are failing since they silently assume that a certain
>> device or the i440fx pc machine is available. Add more checks for CONFIG
>> switches here to not run those tests in case the corresponding device is
>> not available.
> 
> Is this enough to fix this:
> 
> # Check our reduced build configurations
> # requires libfdt: aarch64, arm, loongarch64, microblaze, microblazeel,
> #   or1k, ppc64, riscv32, riscv64, rx
> # fails qtest without boards: i386, x86_64
> build-without-defaults:
> 
> and add i386-softmmu/x86_64-softmmu to build-without-defaults?

Yes, together with some other patches that I sent to the list in the past 
days, this seems to work now:

  https://gitlab.com/thuth/qemu/-/jobs/7751500808#L5050

I just had to discover that I messed up this patch here (forgot to squash 
some other changes). I'll make a proper series out of the patches and send 
them out together again, including a patch to enable x86 in the 
build-without-defaults job.

  Thomas



      reply	other threads:[~2024-09-05 10:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04  8:21 [PATCH] tests/qtest/meson.build: Add more CONFIG switches checks for the x86 tests Thomas Huth
2024-09-05  8:28 ` Paolo Bonzini
2024-09-05 10:52   ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=881fcbd7-d78f-4b42-b1e7-f4321cc9dc2a@redhat.com \
    --to=thuth@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).