qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	Ming Lei <ming.lei@canonical.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.1?!?] AioContext: speed up aio_notify
Date: Fri, 4 Jul 2014 06:40:33 -0400 (EDT)	[thread overview]
Message-ID: <884172955.3547958.1404470433547.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20140704102637.GC4233@noname.redhat.com>

> We have a rather long freeze phase this time (which I think is a good
> thing). This patch fixes a regression, even if it may not be the most
> important one because it is in experimental code. But I still think that
> this time in the hard freeze is the right time to commit patches like
> this. I would be very hesitant with such a patch like in the two weeks
> before the release, but at this point I'm very open to including it.
> 
> All that requiring proper review and testing, of course. I reviewed it
> and it looks good to me and Stefan seems to have reviewed it as well, so
> I think it just needs a bit more testing.

My judgement came from Ming saying that coroutine pools and plug/unplug
alone bring dataplane to the level of 2.0.  It doesn't surprise me that
write to eventfd is so optimized that it matters less than expected.

If this patch is properly tested with rbd and gluster, it's okay for me
to include it.  Still, it feels good that for once I'm the one on the
safe side. ;)

Paolo

  reply	other threads:[~2014-07-04 10:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 16:59 [Qemu-devel] [PATCH for-2.1?!?] AioContext: speed up aio_notify Paolo Bonzini
2014-07-03 18:17 ` Stefan Hajnoczi
2014-07-04  6:51   ` Paolo Bonzini
2014-07-04  7:23     ` Ming Lei
2014-07-04  7:27       ` Paolo Bonzini
2014-07-04 10:26         ` Kevin Wolf
2014-07-04 10:40           ` Paolo Bonzini [this message]
2014-07-07  8:28 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=884172955.3547958.1404470433547.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ming.lei@canonical.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).