From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X30v4-0006ud-Pp
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 06:40:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X30uy-0002NF-Hg
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 06:40:42 -0400
Received: from mx5-phx2.redhat.com ([209.132.183.37]:37946)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X30uy-0002N4-4v
	for qemu-devel@nongnu.org; Fri, 04 Jul 2014 06:40:36 -0400
Date: Fri, 4 Jul 2014 06:40:33 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <884172955.3547958.1404470433547.JavaMail.zimbra@redhat.com>
In-Reply-To: <20140704102637.GC4233@noname.redhat.com>
References: <1404406760-22981-1-git-send-email-pbonzini@redhat.com>
	<CAJSP0QVL6=vcARiwGkS-iBREji+CynQO_NT-doZtmqF7ba7Y1Q@mail.gmail.com>
	<53B64EE6.4000705@redhat.com>
	<CACVXFVN9VDrnopkM2q=Vsuk6_ES6-3_SHswSv5L+7_ToopetYA@mail.gmail.com>
	<53B6576B.7040304@redhat.com>
	<20140704102637.GC4233@noname.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.1?!?] AioContext: speed up aio_notify
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Ming Lei <ming.lei@canonical.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

> We have a rather long freeze phase this time (which I think is a good
> thing). This patch fixes a regression, even if it may not be the most
> important one because it is in experimental code. But I still think that
> this time in the hard freeze is the right time to commit patches like
> this. I would be very hesitant with such a patch like in the two weeks
> before the release, but at this point I'm very open to including it.
> 
> All that requiring proper review and testing, of course. I reviewed it
> and it looks good to me and Stefan seems to have reviewed it as well, so
> I think it just needs a bit more testing.

My judgement came from Ming saying that coroutine pools and plug/unplug
alone bring dataplane to the level of 2.0.  It doesn't surprise me that
write to eventfd is so optimized that it matters less than expected.

If this patch is properly tested with rbd and gluster, it's okay for me
to include it.  Still, it feels good that for once I'm the one on the
safe side. ;)

Paolo