Re: [PATCH RFC v3 08/13] qmp: update virtio features map to support extended features

[Paolo Abeni <pabeni@redhat.com>]

On 7/18/25 12:18 PM, Stefano Garzarella wrote:
> On Fri, Jul 18, 2025 at 10:52:34AM +0200, Paolo Abeni wrote:
>> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
>> index 3b6377cf0d..03c6163cf4 100644
>> --- a/hw/virtio/virtio-qmp.c
>> +++ b/hw/virtio/virtio-qmp.c
>> @@ -325,6 +325,20 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
>>     FEATURE_ENTRY(VHOST_USER_F_PROTOCOL_FEATURES, \
>>             "VHOST_USER_F_PROTOCOL_FEATURES: Vhost-user protocol features "
>>             "negotiation supported"),
>> +    FEATURE_ENTRY(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO, \
>> +            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
>> +            "UDP tunnel packets"),
>> +    FEATURE_ENTRY(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM, \
>> +            "VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO: Driver can receive GSO over "
>> +            "UDP tunnel packets requiring checksum offload for the outer "
>> +            "header"),
>> +    FEATURE_ENTRY(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO, \
>> +            "VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO: Device can receive GSO over "
>> +            "UDP tunnel packets"),
>> +    FEATURE_ENTRY(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO_CSUM, \
>> +            "VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO: Device can receive GSO over "
>> +            "UDP tunnel packets requiring checksum offload for the outer "
>> +            "header"),
> 
> Is this chunk supposed to be here in this patch or better in the last 
> patches where you add UPD tunnel features support?

Note that this point was discussed in the previous iteration:

https://lists.gnu.org/archive/html/qemu-devel/2025-07/msg04418.html

I think it could be both way: it could be useful for QMP to be able to
dump the (kernel/backend) features in human readable format even if qemu
does not support them.

No big objection to move the above chunk in patch 13/13, if there is
agreement :)

/P