qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Cole Robinson <crobinso@redhat.com>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, richard.henderson@linaro.org,
	ehabkost@redhat.com
Subject: Re: [PATCH] tests: tcg: Fix PVH test with binutils 2.36+
Date: Fri, 8 Oct 2021 19:14:04 +0200	[thread overview]
Message-ID: <8847ccd3-f2a5-4834-afba-d27bd735d359@redhat.com> (raw)
In-Reply-To: <5ab2a54c262c61f64c22dbb49ade3e2db8a740bb.1633708346.git.crobinso@redhat.com>

On 08/10/21 18:21, Cole Robinson wrote:
> binutils started adding a .note.gnu.property ELF section which
> makes the PVH test fail:
> 
>    TEST    hello on x86_64
> qemu-system-x86_64: Error loading uncompressed kernel without PVH ELF Note
> 
> Discard .note.gnu* while keeping the PVH .note bits intact.
> 
> This also strips the build-id note, so drop the related comment.
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>   tests/tcg/x86_64/system/kernel.ld | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/tcg/x86_64/system/kernel.ld b/tests/tcg/x86_64/system/kernel.ld
> index 49c12b04ae..ca5d6bd850 100644
> --- a/tests/tcg/x86_64/system/kernel.ld
> +++ b/tests/tcg/x86_64/system/kernel.ld
> @@ -16,7 +16,10 @@ SECTIONS {
>   		*(.rodata)
>   	} :text
>   
> -        /* Keep build ID and PVH notes in same section */
> +        /DISCARD/ : {
> +                *(.note.gnu*)
> +        }
> +
>           .notes :  {
>                  *(.note.*)
>           } :note
> 

Queued, thanks.

Paolo



  reply	other threads:[~2021-10-08 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08 16:21 [PATCH] tests: tcg: Fix PVH test with binutils 2.36+ Cole Robinson
2021-10-08 17:14 ` Paolo Bonzini [this message]
2021-10-10 12:21 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8847ccd3-f2a5-4834-afba-d27bd735d359@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=crobinso@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).