From: Stefan Berger <stefanb@linux.ibm.com>
To: James Bottomley <jejb@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH v6 1/2] tpm: convert tpmdev options processing to new visitor format
Date: Tue, 26 Sep 2023 13:43:12 -0400 [thread overview]
Message-ID: <88565c38-17f7-4518-822f-462d90fd0a32@linux.ibm.com> (raw)
In-Reply-To: <135a0a1d-3219-c537-130f-8e73ff333703@linux.ibm.com>
On 9/26/23 11:20, Stefan Berger wrote:
>
> On 1/9/23 11:15, James Bottomley wrote:
>> From: James Bottomley <James.Bottomley@HansenPartnership.com>
>>
>> Instead of processing the tpmdev options using the old qemu options,
>> convert to the new visitor format which also allows the passing of
>> json on the command line.
>>
>> Signed-off-by: James Bottomley <jejb@linux.ibm.com>
>
>> + while (!QSIMPLEQ_EMPTY(&tco_queue)) {
>> + TpmCreateOptionsQueueEntry *tcoqe = QSIMPLEQ_FIRST(&tco_queue);
>> - return 0;
>> + QSIMPLEQ_REMOVE_HEAD(&tco_queue, entry);
>> + tpm_init_tpmdev(tcoqe->tco);
>
> tcoqe->tco and the possible emulator or passthrough specific
> allocations should probably be also free'ed here.
Use: qapi_free_TpmCreateOptions(tcoqe->tco);
next prev parent reply other threads:[~2023-09-26 17:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 16:15 [PATCH v6 0/2] tpm: add mssim backend James Bottomley
2023-01-09 16:15 ` [PATCH v6 1/2] tpm: convert tpmdev options processing to new visitor format James Bottomley
2023-09-26 15:20 ` Stefan Berger
2023-09-26 17:43 ` Stefan Berger [this message]
2023-01-09 16:15 ` [PATCH v6 2/2] tpm: add backend for mssim James Bottomley
2023-09-22 6:00 ` Markus Armbruster
2023-09-22 12:41 ` Stefan Berger
2023-09-22 13:02 ` Daniel P. Berrangé
2023-09-22 13:27 ` Stefan Berger
2023-09-25 12:12 ` James Bottomley
2023-09-25 12:15 ` James Bottomley
2023-09-25 12:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88565c38-17f7-4518-822f-462d90fd0a32@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).