qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org, Gleb Natapov <gleb@qumranet.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu
Date: Tue, 5 Aug 2008 16:36:21 +0200	[thread overview]
Message-ID: <885A98BA-C9EA-4F72-A066-344CD4046F79@web.de> (raw)
In-Reply-To: <20080805135319.GB3689@minantech.com>


Am 05.08.2008 um 15:53 schrieb Gleb Natapov:

> On Tue, Aug 05, 2008 at 03:43:39PM +0200, Gerd Hoffmann wrote:
>> Chris Lalancette wrote:
>>> As suggested by Anthony, this patch and the next one were split  
>>> apart.  This
>>> patch just adds the basic plumbing to qemu to be able to set the  
>>> uuid on the
>>> command-line, and retrieve the information via "info uuid".
>>
>> What is the point of CONFIG_UUID and the libuuid test in that patch?
>> I can't see any dependency on it in the source code.  IMHO the -uuid
>> switch should be present unconditionally.
> Here is the patch series where there is no CONFIG_UUID test (was  
> posted
> here two month ago):
> http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00443.html
> http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00444.html
>
> And this one checks for libuuid and uses it for random uuid  
> generation if
> available (UUID should be RFC compliant):
> http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00446.html

It seemed general consensus that we don't want values randomly  
generated at runtime in QEMU, rather having some constant, widely  
acceptable value and leaving it to either management tools or the user  
determining them. There was a long discussion about this topic before,  
concerning IPv4 subnets.

I don't really see a use case where we'd want a universally unique ID  
generated by QEMU at runtime either - it would seem better to generate  
it using some external tool (e.g., uuidgen or GUIDgen) and then pass  
the same value as command line argument (or config file option) to a  
certain virtual machine. After all it's supposed to be unique and not  
changing with each QEMU invocation.

Andreas

  reply	other threads:[~2008-08-05 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28 13:25 [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu Chris Lalancette
2008-08-05 13:43 ` Gerd Hoffmann
2008-08-05 13:53   ` Gleb Natapov
2008-08-05 14:36     ` Andreas Färber [this message]
2008-08-05 13:53   ` Chris Lalancette
2008-08-05 14:32     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=885A98BA-C9EA-4F72-A066-344CD4046F79@web.de \
    --to=andreas.faerber@web.de \
    --cc=gleb@qumranet.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).