Re: [PATCH v5 1/2] migration: switchover-hold parameter

[Avihai Horon <avihaih@nvidia.com>]

On 06/07/2023 16:44, Peter Xu wrote:
> External email: Use caution opening links or attachments
>
>
> On Thu, Jul 06, 2023 at 04:29:22PM +0300, Avihai Horon wrote:
>>> diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
>>> index 9885d7c9f7..c3b3860f00 100644
>>> --- a/migration/migration-hmp-cmds.c
>>> +++ b/migration/migration-hmp-cmds.c
>>> @@ -338,6 +338,9 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>>>            monitor_printf(mon, "%s: '%s'\n",
>>>                MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
>>>                params->tls_authz);
>>> +        monitor_printf(mon, "%s: %s\n",
>>> +            MigrationParameter_str(MIGRATION_PARAMETER_SWITCHOVER_HOLD),
>>> +            params->switchover_hold ? "on" : "off");
>>>
>>>            if (params->has_block_bitmap_mapping) {
>>>                const BitmapMigrationNodeAliasList *bmnal;
>>> @@ -616,6 +619,10 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
>>>            p->has_announce_step = true;
>>>            visit_type_size(v, param, &p->announce_step, &err);
>>>            break;
>>> +    case MIGRATION_PARAMETER_SWITCHOVER_HOLD:
>>> +        p->has_switchover_hold = true;
>>> +        visit_type_bool(v, param, &p->switchover_hold, &err);
>> Should this sem post switchover_hold_sem like in the QMP case?
> hmp_migrate_set_parameter() calls qmp_migrate_set_parameters() later, so
> it'll be posted there.

Oh right, I missed that.

Thanks.