From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40080)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X3mkv-0006Bx-3K
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 09:45:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X3mko-0000Ie-TF
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 09:45:25 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:37757)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X3mko-0000IK-Hk
	for qemu-devel@nongnu.org; Sun, 06 Jul 2014 09:45:18 -0400
Date: Sun, 6 Jul 2014 09:45:13 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <88648946.3917617.1404654313489.JavaMail.zimbra@redhat.com>
In-Reply-To: <20140706061538.GA7425@redhat.com>
References: <1404375987-29810-1-git-send-email-tamlokveer@gmail.com>
	<20140703082852.GC20580@redhat.com>
	<20140706061538.GA7425@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] for-2.1 (was Re: [PATCH] ahci: map memory via
 device's address space instead of address_space_memory)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, peter maydell <peter.maydell@linaro.org>, Le Tan <tamlokveer@gmail.com>, qemu-devel@nongnu.org, jan kiszka <jan.kiszka@web.de>, stefanha@redhat.com, afaerber@suse.de


> Stefan, Kevin, you are going to pick this one?

I think there's no hurry for 2.1.

Also...

> > > ---
> > > -static void map_page(uint8_t **ptr, uint64_t addr, uint32_t wanted)
> > > +static void map_page(AddressSpace *as, uint8_t **ptr, uint64_t addr,
> > > +                     uint32_t wanted)

... it is a bit cleaner to pass the AHCIState here.

Paolo