From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, Peter Maydell <peter.maydell@linaro.org>,
Daniel Berrange <berrange@redhat.com>
Subject: Re: [PATCH v2] docs/system: clarify deprecation schedule
Date: Tue, 15 Sep 2020 17:36:39 +0200 [thread overview]
Message-ID: <886e82e6-2015-9939-4bb6-dc93ec58c2fb@redhat.com> (raw)
In-Reply-To: <20200915150734.711426-1-stefanha@redhat.com>
On 9/15/20 5:07 PM, Stefan Hajnoczi wrote:
> The sentence explaining the deprecation schedule is ambiguous. Make it
> clear that a feature deprecated in the Nth release is guaranteed to
> remain available in the N+1th release. Removal can occur in the N+2nd
> release or later.
>
> As an example of this in action, see commit
> 25956af3fe5dd0385ad8017bc768a6afe41e2a74 ("block: Finish deprecation of
> 'qemu-img convert -n -o'"). The feature was deprecated in QEMU 4.2.0. It
> was present in the 5.0.0 release and removed in the 5.1.0 release.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2:
> * Use Dan's suggested wording [Daniel Berrange]
> ---
> docs/system/deprecated.rst | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 0cb8b01424..f2d5bd8ce1 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -3,10 +3,11 @@ Deprecated features
>
> In general features are intended to be supported indefinitely once
> introduced into QEMU. In the event that a feature needs to be removed,
> -it will be listed in this section. The feature will remain functional
> -for 2 releases prior to actual removal. Deprecated features may also
> -generate warnings on the console when QEMU starts up, or if activated
> -via a monitor command, however, this is not a mandatory requirement.
> +it will be listed in this section. The feature will remain functional for the
> +release in which it was deprecated and one further release. After these two
> +releases, the feature is liable to be removed. Deprecated features may also
> +generate warnings on the console when QEMU starts up, or if activated via a
> +monitor command, however, this is not a mandatory requirement.
>
> Prior to the 2.10.0 release there was no official policy on how
> long features would be deprecated prior to their removal, nor
>
next prev parent reply other threads:[~2020-09-15 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 15:07 [PATCH v2] docs/system: clarify deprecation schedule Stefan Hajnoczi
2020-09-15 15:28 ` Daniel P. Berrangé
2020-09-15 15:36 ` Philippe Mathieu-Daudé [this message]
2020-09-23 12:42 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=886e82e6-2015-9939-4bb6-dc93ec58c2fb@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=libvir-list@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).