From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Guenter Roeck <linux@roeck-us.net>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Bin Meng <bmeng.cn@gmail.com>, Jason Wang <jasowang@redhat.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Jean-Christophe Dubois <jcd@tribudubois.net>
Subject: Re: [PATCH] hw/net/imx_fec: return 0xffff when accessing non-existing PHY
Date: Sun, 2 May 2021 18:12:53 +0200 [thread overview]
Message-ID: <889183f9-1f17-dbdd-787d-76f9b5956bca@amsat.org> (raw)
In-Reply-To: <20210502160326.1196252-1-linux@roeck-us.net>
On 5/2/21 6:03 PM, Guenter Roeck wrote:
> If a PHY does not exist, attempts to read from it should return 0xffff.
> Otherwise the Linux kernel will believe that a PHY is there and select
> the non-existing PHY. This in turn will result in network errors later
> on since the real PHY is not selected or configured.
>
> Since reading from or writing to a non-existing PHY is not an emulation
> error, replace guest error messages with traces.
>
> Fixes: 461c51ad4275 ("Add a phy-num property to the i.MX FEC emulator")
> Cc: Jean-Christophe Dubois <jcd@tribudubois.net>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> hw/net/imx_fec.c | 8 +++-----
> hw/net/trace-events | 2 ++
> 2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-05-02 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 16:03 [PATCH] hw/net/imx_fec: return 0xffff when accessing non-existing PHY Guenter Roeck
2021-05-02 16:09 ` Bin Meng
2021-05-02 16:14 ` Guenter Roeck
2021-05-06 2:24 ` Jason Wang
2021-05-06 3:04 ` Guenter Roeck
2021-05-02 16:12 ` Philippe Mathieu-Daudé [this message]
2021-05-06 2:23 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=889183f9-1f17-dbdd-787d-76f9b5956bca@amsat.org \
--to=f4bug@amsat.org \
--cc=bmeng.cn@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=linux@roeck-us.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).