From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33132)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1UO8oK-0007Ox-H7
	for qemu-devel@nongnu.org; Fri, 05 Apr 2013 11:44:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1UO8oF-00056g-1U
	for qemu-devel@nongnu.org; Fri, 05 Apr 2013 11:44:16 -0400
Received: from mail.avalus.com ([2001:41c8:10:1dd::10]:43040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex@alex.org.uk>) id 1UO8oE-00055b-SJ
	for qemu-devel@nongnu.org; Fri, 05 Apr 2013 11:44:10 -0400
Date: Fri, 05 Apr 2013 16:43:52 +0100
From: Alex Bligh <alex@alex.org.uk>
Message-ID: <889B9F24349667899BF0247D@nimrod.local>
In-Reply-To: <alpine.DEB.2.02.1304051516460.5078@kaball.uk.xensource.com>
References: <alpine.DEB.2.02.1304021208110.5078@kaball.uk.xensource.com>
	<1365157905-22987-1-git-send-email-alex@alex.org.uk>
	<alpine.DEB.2.02.1304051516460.5078@kaball.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Re: [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to
 bdrv_new from blk_init to blk_connect
Reply-To: Alex Bligh <alex@alex.org.uk>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, qemu-devel@nongnu.org, xen-devel <xen-devel@lists.xen.org>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Alex Bligh <alex@alex.org.uk>

Stefano,

--On 5 April 2013 15:22:16 +0100 Stefano Stabellini 
<stefano.stabellini@eu.citrix.com> wrote:

>> @@ -756,6 +753,41 @@ static int blk_init(struct XenDevice *xendev)
>>          info  |= VDISK_CDROM;
>>      }
>>
>> +    blkdev->file_blk  = BLOCK_SIZE;
>
> This is useless, you are setting file_blk twice. Just remove this please.

Actually the problem was I failed to remove it from blk_connect on the
qemu-upstream-unstable patch set. The qemu-upstream-4.2 patch set is fine.

I've thus resent, with it still in blk_init, but removed from blk_connect.

-- 
Alex Bligh