Re: [Qemu-devel] [PATCH v3 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

[Paul Durrant <Paul.Durrant@citrix.com>]

> -----Original Message-----
> From: Anthony PERARD [mailto:anthony.perard@citrix.com]
> Sent: 11 December 2018 15:17
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: qemu-devel@nongnu.org; qemu-block@nongnu.org; xen-
> devel@lists.xenproject.org; Kevin Wolf <kwolf@redhat.com>; Max Reitz
> <mreitz@redhat.com>; Stefano Stabellini <sstabellini@kernel.org>
> Subject: Re: [PATCH v3 03/18] xen: introduce 'xen-block', 'xen-disk' and
> 'xen-cdrom'
> 
> On Tue, Dec 11, 2018 at 10:47:03AM +0000, Paul Durrant wrote:
> > This patch adds new XenDevice-s: 'xen-disk' and 'xen-cdrom', both
> derived
> > from a common 'xen-block' parent type. These will eventually replace the
> > 'xen_disk' (note the underscore rather than hyphen) legacy PV backend
> but
> > it is illustrative to build up the implementation incrementally, along
> with
> > the XenBus/XenDevice framework. Subsequent patches will therefore add to
> > these devices' implementation as new features are added to the
> framework.
> >
> > After this patch has been applied it is possible to instantiate new
> > 'xen-disk' or 'xen-cdrom' devices with a single 'vdev' parameter, which
> > accepts values adhering to the Xen VBD naming scheme [1]. For example, a
> > command-line instantiation of a xen-disk can be done with an argument
> > similar to the following:
> >
> > -device xen-disk,vdev=hda
> >
> > The implementation of the vdev parameter formulates the appropriate VBD
> > number for use in the PV protocol.
> >
> > [1] https://xenbits.xen.org/docs/unstable/man/xen-vbd-interface.7.html
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> 
> Now we can add a xen-disk with vdev=xvdbgqcv :)

Yep, you can keep going until xenstore explodes :-)

  Paul

> 
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Thanks,
> 
> --
> Anthony PERARD