Re: [PATCH] ui/dbus: Implement damage regions for GL

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 9/5/23 17:04, Bilal Elmoussaoui wrote:
>     cairo declared as optional dep, ...
> 
> 
> I don't see where cairo is marked as an optional dependency, the `cairo 
> = not_found` part could probably be dropped to make it clearer.

I was expecting:

.require(cairo.found(), error_message: '-display dbus requires cairo')

> 
> On Tue, May 9, 2023 at 4:34 PM Philippe Mathieu-Daudé <philmd@linaro.org 
> <mailto:philmd@linaro.org>> wrote:
> 
>     Hi,
> 
>     On 9/5/23 13:59, Bilal Elmoussaoui wrote:
>      > From: Christian Hergert <chergert@redhat.com
>     <mailto:chergert@redhat.com>>


>      > diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
>      > index 911acdc529..047be5cb3a 100644
>      > --- a/ui/dbus-listener.c
>      > +++ b/ui/dbus-listener.c
>      > @@ -25,6 +25,7 @@
>      >   #include "qemu/error-report.h"
>      >   #include "sysemu/sysemu.h"
>      >   #include "dbus.h"
>      > +#include <cairo.h>
> 
>     cairo used unconditionally.
> 
>     Shouldn't we now declared it as a strict dependency in meson?
> 
>      >   #include <gio/gunixfdlist.h>
>      >
>      >   #ifdef CONFIG_OPENGL
>