From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62352C7EE22 for ; Tue, 9 May 2023 15:19:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwP6w-0005v8-T6; Tue, 09 May 2023 11:18:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwP6u-0005ud-Qb for qemu-devel@nongnu.org; Tue, 09 May 2023 11:18:41 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwP6t-00081A-5E for qemu-devel@nongnu.org; Tue, 09 May 2023 11:18:40 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-2fe3fb8e25fso3973215f8f.0 for ; Tue, 09 May 2023 08:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683645516; x=1686237516; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oSWcK0VCYW4tbQwNCGOEfZ3AZKfPFukyqoVA20OuVbA=; b=u7nJsLcsBlj9H2h7Dc8PjyMnCjqLIHV96UlXGxMmatNcuwKLSSA0MHuerqPMKt0oFN eNEAKE4grDghWtKyl9n9p6vwzh8/nHk9wiPMUlUH6A6BdWrmZvsxAFJlBDIlrkKzoCkx GyA8nS345NLo0wzRMFAYv50pH3oXiu1kg8tqpM1mmacamn6805t87aCkJtL3xMH8MsN1 0VyFlY7GEudisFYNPSGyX0ZWSJYDC5czsZRfZIuQ8L0Q3BhDgfGZRKT19xDH4iIsSSkt t2kK3ODh7L4hlRmNxAxb8RXigMG21xTy37Ym0QobV3anDqe9ifo9xVufEXQolvJ8WWEr YK7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683645516; x=1686237516; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oSWcK0VCYW4tbQwNCGOEfZ3AZKfPFukyqoVA20OuVbA=; b=OcirrzxpfWZmd9ZsB44F0ivg2+BAt9qpRYjwf6q71z7k1f+XIvasmluakzRA2QT8cC 8ZUwepXRJW8t68tnFP6CpspLSlN2FjzS4rcANuiJbzKAkowu7fXqh9UbPxcOcRaOXAf0 2mQzAV6QRbsah+sONISCFDGu3nbJIxy4Pfge3mF33v/yh0x7dKPdZAmtul25gfsbrNb0 PKvDzM24YdJdKw+ladEpzZ1P+tYE78RIA+vDdedoO8IRp0esmQII3YZ8iZdbyN+n6tSL Wp5WDYrMWlLSjZQi8cWV3/s62YsihQNoRu78YMCVB48o2B321LZHqL7ur5n4G87iS/Wy hPDQ== X-Gm-Message-State: AC+VfDzSUomsLITj57dB8G2WB7uZqDaPFZRp1B7kx+iqbauhtBNLtEun Hn5Sdx7IwpXiQd+BuMMx1TAyIg== X-Google-Smtp-Source: ACHHUZ5x31lWeFxh8MpDOPrw5xFxoxRKolJjozS+hJcny8Lp4GKK9HfgC2JfDzLgWxcsFF8bQylkAw== X-Received: by 2002:adf:ff84:0:b0:306:2aa0:ce81 with SMTP id j4-20020adfff84000000b003062aa0ce81mr10320668wrr.30.1683645516441; Tue, 09 May 2023 08:18:36 -0700 (PDT) Received: from [192.168.69.115] ([176.187.211.62]) by smtp.gmail.com with ESMTPSA id c17-20020a5d4f11000000b003079986fd71sm5560627wru.88.2023.05.09.08.18.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 08:18:36 -0700 (PDT) Message-ID: <88b44aa5-c7b2-3cad-b3cf-e69d312c66b9@linaro.org> Date: Tue, 9 May 2023 17:18:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] ui/dbus: Implement damage regions for GL Content-Language: en-US To: Bilal Elmoussaoui Cc: qemu-devel@nongnu.org, Thomas Huth , Gerd Hoffmann , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , chergert@redhat.com, Paolo Bonzini , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <20230509115940.114033-1-belmouss@redhat.com> <00958ee1-4c47-20e9-bcd0-ed92179ee831@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.421, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 9/5/23 17:04, Bilal Elmoussaoui wrote: > cairo declared as optional dep, ... > > > I don't see where cairo is marked as an optional dependency, the `cairo > = not_found` part could probably be dropped to make it clearer. I was expecting: .require(cairo.found(), error_message: '-display dbus requires cairo') > > On Tue, May 9, 2023 at 4:34 PM Philippe Mathieu-Daudé > wrote: > > Hi, > > On 9/5/23 13:59, Bilal Elmoussaoui wrote: > > From: Christian Hergert > > > diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c > > index 911acdc529..047be5cb3a 100644 > > --- a/ui/dbus-listener.c > > +++ b/ui/dbus-listener.c > > @@ -25,6 +25,7 @@ > >   #include "qemu/error-report.h" > >   #include "sysemu/sysemu.h" > >   #include "dbus.h" > > +#include > > cairo used unconditionally. > > Shouldn't we now declared it as a strict dependency in meson? > > >   #include > > > >   #ifdef CONFIG_OPENGL >