Re: [Qemu-devel] [PATCH] tests: check-qom-proplist: fix leak

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

On 06/09/2017 10:34 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> On 06/09/2017 08:33 AM, Marc-André Lureau wrote:
>>> user_creatable_add_opts() returns a reference (the other reference is
>>> for the root parent/child link).
>>>
>>> Leak introduced in commit a1af255f065cc.
>>>
>>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>> ---
>>>  tests/check-qom-proplist.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
>>> index 8e432e9ab6..a3cd7ab29f 100644
>>> --- a/tests/check-qom-proplist.c
>>> +++ b/tests/check-qom-proplist.c
>>> @@ -428,6 +428,8 @@ static void test_dummy_createcmdl(void)
>>>      g_assert(err == NULL);
>>>      error_free(err);
>>>  
>>> +    object_unref(OBJECT(dobj));
>>
>> This should be spelled QDECREF(dobj);
> 
> Caution, this is object_unref(), not qobject_decref().

Indeed - now that I re-read it closely, I see that you are right.  Oh
well - I didn't waste much time improving the qobject coccinelle script,
even though this patch proposal is unrelated to that one. :)

> 
> We suck at naming.

Not the first time.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]