From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBsi4-0001f7-MR for qemu-devel@nongnu.org; Sun, 05 Jul 2015 18:48:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBsi0-0002WI-8z for qemu-devel@nongnu.org; Sun, 05 Jul 2015 18:48:28 -0400 Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:36334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBsi0-0002Vf-0x for qemu-devel@nongnu.org; Sun, 05 Jul 2015 18:48:24 -0400 Received: by lagc2 with SMTP id c2so134519672lag.3 for ; Sun, 05 Jul 2015 15:48:23 -0700 (PDT) From: Dmitry Osipenko Date: Mon, 6 Jul 2015 01:47:47 +0300 Message-Id: <88cc97fb7c00f9bf0155ab0d40b61d20297cf992.1436133989.git.digetx@gmail.com> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH v2 1/2] arm_mptimer: Fix timer shutdown and mode change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Peter Maydell Cc: Paolo Bonzini , QEMU Developers The running timer can't be stopped because timer control code just doesn't handle disabling the timer. Fix it by deleting the timer if the enable bit is cleared. The timer won't start periodic ticking if a ONE-SHOT -> PERIODIC mode change happens after a one-shot tick was completed. Fix it by re-starting ticking if the timer isn't ticking right now. To avoid code churning, these two fixes are squashed in one commit. Signed-off-by: Dmitry Osipenko Reviewed-by: Peter Crosthwaite --- v1: Commits are squashed as per Peter Crosthwaite suggestion. v2: Grammar fixes of commit message as per Peter Crosthwaite suggestion. hw/timer/arm_mptimer.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c index 8b93b3c..0e132b1 100644 --- a/hw/timer/arm_mptimer.c +++ b/hw/timer/arm_mptimer.c @@ -122,11 +122,18 @@ static void timerblock_write(void *opaque, hwaddr addr, case 8: /* Control. */ old = tb->control; tb->control = value; - if (((old & 1) == 0) && (value & 1)) { - if (tb->count == 0 && (tb->control & 2)) { + if (value & 1) { + if ((old & 1) && (tb->count != 0)) { + /* Do nothing if timer is ticking right now. */ + break; + } + if (tb->control & 2) { tb->count = tb->load; } timerblock_reload(tb, 1); + } else if (old & 1) { + /* Shutdown the timer. */ + timer_del(tb->timer); } break; case 12: /* Interrupt status. */ -- 2.4.4