From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"John Snow" <jsnow@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
devel@lists.libvirt.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 2/5] include/hw/boards: cope with dev/rc versions in deprecation checks
Date: Tue, 29 Apr 2025 17:26:56 +0200 [thread overview]
Message-ID: <88e2d90b-5a58-4fa9-a98c-21fc29ace779@redhat.com> (raw)
In-Reply-To: <20250429131526.1842130-3-berrange@redhat.com>
On 29/04/2025 15.15, Daniel P. Berrangé wrote:
> When VERSION is set to a development snapshot (micro >= 50), or a release
> candidate (micro >= 90) we have an off-by-1 in determining deprecation
> and deletion thresholds for versioned machine types. In such cases we need
> to use the next major/minor version in threshold checks.
>
> This adapts the deprecation macros to do "next version" prediction when
> seeing a dev/rc version number.
>
> This ensures users of release candidates get an accurate view of machines
> that will be deprecated/deleted in the final release.
>
> This requires hardcoding our current release policy of 3 releases per
> year, with a major bump at the start of each year, and that dev/rc
> versions have micro >= 50.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> include/hw/boards.h | 33 ++++++++++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-04-29 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 13:15 [PATCH v2 0/5] docs: automated info about machine deprecation/removal info Daniel P. Berrangé
2025-04-29 13:15 ` [PATCH v2 1/5] Revert "include/hw: temporarily disable deletion of versioned machine types" Daniel P. Berrangé
2025-04-29 14:30 ` Thomas Huth
2025-04-29 15:06 ` Daniel P. Berrangé
2025-04-29 13:15 ` [PATCH v2 2/5] include/hw/boards: cope with dev/rc versions in deprecation checks Daniel P. Berrangé
2025-04-29 15:26 ` Thomas Huth [this message]
2025-04-29 13:15 ` [PATCH v2 3/5] docs/about/deprecated: auto-generate a note for versioned machine types Daniel P. Berrangé
2025-04-29 15:29 ` Thomas Huth
2025-04-29 13:15 ` [PATCH v2 4/5] docs/about/removed-features: " Daniel P. Berrangé
2025-04-30 10:16 ` Thomas Huth
2025-04-29 13:15 ` [PATCH v2 5/5] include/hw/boards: add warning about changing deprecation logic Daniel P. Berrangé
2025-05-11 18:24 ` [PATCH v2 0/5] docs: automated info about machine deprecation/removal info Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e2d90b-5a58-4fa9-a98c-21fc29ace779@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).