From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pkrempa@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
vsementsov@virtuozzo.com, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH RFC v2 2/5] blockdev: combine DriveBackupState and BlockdevBackupState
Date: Mon, 18 May 2020 15:57:43 -0500 [thread overview]
Message-ID: <88e3bb16-8f67-cd00-a1ae-6b6fd4341d71@redhat.com> (raw)
In-Reply-To: <20200514034922.24834-3-jsnow@redhat.com>
On 5/13/20 10:49 PM, John Snow wrote:
> They have the same fields -- rename it BlockJobState.
This says BlockJobState...
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> blockdev.c | 30 ++++++++++++------------------
> 1 file changed, 12 insertions(+), 18 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index b3c840ec03..d3e8a6ca22 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -1702,11 +1702,11 @@ static void external_snapshot_clean(BlkActionState *common)
> aio_context_release(aio_context);
> }
>
> -typedef struct DriveBackupState {
> +typedef struct BlockJobActionState {
...but this does not. I'm assuming it is just a typo in the commit message?
Otherwise,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-18 20:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 3:49 [PATCH RFC v2 0/5] block: add block-dirty-bitmap-populate job John Snow
2020-05-14 3:49 ` [PATCH RFC v2 1/5] block: add bitmap-populate job John Snow
2020-05-18 20:49 ` Eric Blake
2020-05-19 8:27 ` Peter Krempa
2020-06-04 9:12 ` Kevin Wolf
2020-06-04 9:16 ` Peter Krempa
2020-06-04 11:31 ` Kevin Wolf
2020-06-04 16:22 ` Peter Krempa
2020-06-05 9:01 ` Kevin Wolf
2020-06-05 9:24 ` Peter Krempa
2020-06-05 9:44 ` Kevin Wolf
2020-06-05 9:58 ` Peter Krempa
2020-06-05 10:07 ` Kevin Wolf
2020-06-05 10:59 ` Peter Krempa
2020-06-06 6:55 ` Vladimir Sementsov-Ogievskiy
2020-06-08 9:21 ` Kevin Wolf
2020-06-08 10:00 ` Vladimir Sementsov-Ogievskiy
2020-06-08 13:15 ` Kevin Wolf
2020-06-08 9:38 ` Peter Krempa
2020-06-08 10:30 ` Vladimir Sementsov-Ogievskiy
2020-06-08 12:01 ` Peter Krempa
2020-06-04 9:01 ` Kevin Wolf
2020-06-16 19:46 ` Eric Blake
2020-06-16 19:51 ` John Snow
2020-06-16 20:02 ` Eric Blake
2020-06-17 10:57 ` Kevin Wolf
2020-05-14 3:49 ` [PATCH RFC v2 2/5] blockdev: combine DriveBackupState and BlockdevBackupState John Snow
2020-05-18 20:57 ` Eric Blake [this message]
2020-05-14 3:49 ` [PATCH RFC v2 3/5] qmp: expose block-dirty-bitmap-populate John Snow
2020-05-18 21:10 ` Eric Blake
2020-05-14 3:49 ` [PATCH RFC v2 4/5] iotests: move bitmap helpers into their own file John Snow
2020-05-14 3:49 ` [PATCH RFC v2 5/5] iotests: add 287 for block-dirty-bitmap-populate John Snow
2020-05-18 21:22 ` Eric Blake
2020-06-04 9:24 ` Kevin Wolf
2020-05-18 14:52 ` [PATCH RFC v2 0/5] block: add block-dirty-bitmap-populate job Peter Krempa
2020-06-09 15:04 ` Peter Krempa
2020-06-05 21:51 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e3bb16-8f67-cd00-a1ae-6b6fd4341d71@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).