qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	"Max Reitz" <mreitz@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Caio Carrara" <ccarrara@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img
Date: Tue, 13 Nov 2018 09:43:49 -0500	[thread overview]
Message-ID: <88fd00ad-fef7-6233-c458-bc9c712e510b@redhat.com> (raw)
In-Reply-To: <20181113143223.GK12503@habkost.net>


On 11/13/18 9:32 AM, Eduardo Habkost wrote:
> On Tue, Nov 13, 2018 at 09:20:11AM -0500, Cleber Rosa wrote:
> 
> With check-venv, we made "installing avocado" a small
> implementation detail that people don't need to care about when
> running the tests.
> 
> I believe the sentence "which must be installed separately" is
> now confusing and misleading.  It can be easily interpreted as
> "must be installed manually by the user", which is not case.
> 

Yeah, it can be confusing.  Maybe something like:

These tests are written using the Avocado Testing Framework (which must
either be manually installed, or automatically as part of ``make
check-acceptance``)...

- Cleber.

  reply	other threads:[~2018-11-13 14:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 22:12 [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img Cleber Rosa
2018-11-09 22:12 ` [Qemu-devel] [RFC PATCH 1/2] Acceptance Tests: add QemuImgTest base class Cleber Rosa
2018-11-09 22:12 ` [Qemu-devel] [RFC PATCH 2/2] qemu-img: consider a zero number of I/O requests an invalid count Cleber Rosa
2018-11-12 14:38   ` Philippe Mathieu-Daudé
2018-11-12 15:04     ` Cleber Rosa
2018-11-12 10:49 ` [Qemu-devel] [RFC PATCH 0/2] Acceptance tests for qemu-img Kevin Wolf
2018-11-12 14:59   ` Cleber Rosa
2018-11-12 15:11     ` Daniel P. Berrangé
2018-11-12 16:00     ` Kevin Wolf
2018-11-12 17:36       ` Cleber Rosa
2018-11-13  9:39         ` Markus Armbruster
2018-11-13 13:50           ` Daniel P. Berrangé
2018-11-13 14:41             ` Cleber Rosa
2018-11-13 12:18         ` Kevin Wolf
2018-11-13 13:26           ` Eduardo Habkost
2018-11-13 13:51             ` Kevin Wolf
2018-11-13 13:56               ` Eduardo Habkost
2018-11-13 14:20               ` Cleber Rosa
2018-11-13 14:32                 ` Eduardo Habkost
2018-11-13 14:43                   ` Cleber Rosa [this message]
2018-11-13 14:51                     ` Eduardo Habkost
2018-11-13 14:15           ` Cleber Rosa
2018-11-13 15:38             ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88fd00ad-fef7-6233-c458-bc9c712e510b@redhat.com \
    --to=crosa@redhat.com \
    --cc=ccarrara@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).