From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1gS6ZQ-0003sf-7T
	for qemu-devel@nongnu.org; Wed, 28 Nov 2018 15:36:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1gS6ZK-000840-DP
	for qemu-devel@nongnu.org; Wed, 28 Nov 2018 15:36:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37672)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <lvivier@redhat.com>) id 1gS6ZK-00083S-5r
	for qemu-devel@nongnu.org; Wed, 28 Nov 2018 15:36:22 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
	[10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 89AAD12B9F
	for <qemu-devel@nongnu.org>; Wed, 28 Nov 2018 20:36:21 +0000 (UTC)
References: <20181126200009.862-1-quintela@redhat.com>
	<20181126200009.862-14-quintela@redhat.com>
From: Laurent Vivier <lvivier@redhat.com>
Message-ID: <8901653b-36b3-ae3e-bf94-db4a031e349c@redhat.com>
Date: Wed, 28 Nov 2018 21:36:16 +0100
MIME-Version: 1.0
In-Reply-To: <20181126200009.862-14-quintela@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 13/16] virtio: split virtio serial bits
 rom virtio-pci
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, peterx@redhat.com

On 26/11/2018 21:00, Juan Quintela wrote:
> Virtio console and qga tests also depend on CONFIG_VIRTIO_SERIAL.
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  hw/virtio/Makefile.objs       |   1 +
>  hw/virtio/virtio-pci.c        |  75 -----------------------
>  hw/virtio/virtio-pci.h        |  14 -----
>  hw/virtio/virtio-serial-pci.c | 112 ++++++++++++++++++++++++++++++++++
>  tests/Makefile.include        |   6 +-
>  5 files changed, 116 insertions(+), 92 deletions(-)
>  create mode 100644 hw/virtio/virtio-serial-pci.c
> 

Reviewed-by: Laurent Vivier <lvivier@redhat.com>