From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crPat-0007MN-Ld for qemu-devel@nongnu.org; Fri, 24 Mar 2017 09:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crPas-0006qE-Rw for qemu-devel@nongnu.org; Fri, 24 Mar 2017 09:49:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39082) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crPas-0006pv-Iz for qemu-devel@nongnu.org; Fri, 24 Mar 2017 09:49:30 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 907A780463 for ; Fri, 24 Mar 2017 13:49:30 +0000 (UTC) References: <1490266548-22500-1-git-send-email-armbru@redhat.com> <1490266548-22500-5-git-send-email-armbru@redhat.com> <59a3aed6-e1cf-a601-4369-1a7cd74500cc@redhat.com> <20170324035537.GA22342@localhost.localdomain> <87fui3yx0y.fsf@dusky.pond.sub.org> <20170324124213.GC22342@localhost.localdomain> From: Eric Blake Message-ID: <89101331-9bba-fb6c-42a1-dfce7775fe4c@redhat.com> Date: Fri, 24 Mar 2017 08:49:20 -0500 MIME-Version: 1.0 In-Reply-To: <20170324124213.GC22342@localhost.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PpiwWT0nxDCevd053itJ44BcD92XeXk7P" Subject: Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , Markus Armbruster Cc: kwolf@redhat.com, jdurgin@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, dillaman@redhat.com, "Daniel P. Berrange" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PpiwWT0nxDCevd053itJ44BcD92XeXk7P From: Eric Blake To: Jeff Cody , Markus Armbruster Cc: kwolf@redhat.com, jdurgin@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, dillaman@redhat.com, "Daniel P. Berrange" Message-ID: <89101331-9bba-fb6c-42a1-dfce7775fe4c@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct References: <1490266548-22500-1-git-send-email-armbru@redhat.com> <1490266548-22500-5-git-send-email-armbru@redhat.com> <59a3aed6-e1cf-a601-4369-1a7cd74500cc@redhat.com> <20170324035537.GA22342@localhost.localdomain> <87fui3yx0y.fsf@dusky.pond.sub.org> <20170324124213.GC22342@localhost.localdomain> In-Reply-To: <20170324124213.GC22342@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/24/2017 07:42 AM, Jeff Cody wrote: > Agree. My preference is to leave it as an array of methods, so long as= that > is tenable to libvirt. The -drive syntax should remain unchanged (that's an absolute must for libvirt). But the QMP syntax being an array of methods sounds best to me, and I think password-secret should be part of the array. So my vote would be for: { "driver": "rbd", "image": "foo", "auth": [ { "type": "cephx", "password-secret": "sec0" }, { "type": "none" } ], "pool": "bar" } It makes mapping -drive arguments into QMP form a bit trickier, but the QMP form is then easily extensible if we add another auth method down the road. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PpiwWT0nxDCevd053itJ44BcD92XeXk7P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJY1SPgAAoJEKeha0olJ0Nqjy8H/3DkbDDaS0zTA54NelDqXJIY AAMd77PKyoLgXELkV9z0tmnyHIrnpxlAD3ObPlrYwc/HiXn1uVoUVGvp2yQLjZ/M HNDXq9QjCmftulWnendn4CEq9xVtGj6zTA7klkf6yiOQjcDP8F1JI61kwjAeXoqD zKSm+LJ9eZ+LIkVlI+QzlJpzF5aYaikahQyx+YSqpDkQNnVAVHW41hL7VFzaLwi4 2Uy/yEynuwcZ2uWe3YepO4avVYug03K8li0T25M0N8LcPNg78OCWdfr0b3/wiswm TWZ9U9OS+UGqHAjsQF0Qj8Vt3parz8uEQxEnFcmm3DfOvPOINQm7mDa1R0YYIgs= =DwuI -----END PGP SIGNATURE----- --PpiwWT0nxDCevd053itJ44BcD92XeXk7P--