qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: sgx: mark device not user creatable
Date: Tue, 9 Nov 2021 18:57:14 +0100	[thread overview]
Message-ID: <8918a268-9fe7-fc7e-3c7a-066a4b028b9b@redhat.com> (raw)
In-Reply-To: <20211109175021.17813-1-pbonzini@redhat.com>

On 09/11/2021 18.50, Paolo Bonzini wrote:
> The device is created by the machine based on the sgx-epc property.
> It should not be created by users.
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/i386/sgx-epc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/i386/sgx-epc.c b/hw/i386/sgx-epc.c
> index 55e2217eae..e508827e78 100644
> --- a/hw/i386/sgx-epc.c
> +++ b/hw/i386/sgx-epc.c
> @@ -154,6 +154,7 @@ static void sgx_epc_class_init(ObjectClass *oc, void *data)
>       dc->realize = sgx_epc_realize;
>       dc->unrealize = sgx_epc_unrealize;
>       dc->desc = "SGX EPC section";
> +    dc->user_creatable = false;
>       device_class_set_props(dc, sgx_epc_properties);
>   
>       mdc->get_addr = sgx_epc_md_get_addr;
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2021-11-09 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 17:50 [PATCH] target/i386: sgx: mark device not user creatable Paolo Bonzini
2021-11-09 17:57 ` Thomas Huth [this message]
2021-11-11 14:02 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8918a268-9fe7-fc7e-3c7a-066a4b028b9b@redhat.com \
    --to=thuth@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).