qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Sergei Trofimovich <slyfox@gentoo.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Rafael Kitover" <rkitover@gmail.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] meson.build: tweak sdl-image error message
Date: Tue, 8 Sep 2020 09:49:36 +0200	[thread overview]
Message-ID: <89434eee-42cb-62db-32f7-9bb0dd7c31ea@redhat.com> (raw)
In-Reply-To: <20200908074016.2593596-1-slyfox@gentoo.org>

On 9/8/20 9:40 AM, Sergei Trofimovich wrote:
> Before the change missing SDL was reported as:
> 
>     ../meson.build:253:4: ERROR: Expected 1 arguments, got 2.
> 
> After the error as:
> 
>     ../meson.build:258:4: ERROR: Problem encountered: sdl-image required, but SDL was not found
> 
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> CC: "Philippe Mathieu-Daudé" <philmd@redhat.com>
> CC: Rafael Kitover <rkitover@gmail.com>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 04e070bb3b..7fd2a903c5 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -255,8 +255,8 @@ if sdl.found()
>                           method: 'pkg-config', static: enable_static)
>  else
>    if get_option('sdl_image').enabled()
> -    error('sdl-image required, but SDL was @0@',
> -          get_option('sdl').disabled() ? 'disabled' : 'not found')
> +    error('sdl-image required, but SDL was @0@'.format(
> +          get_option('sdl').disabled() ? 'disabled' : 'not found'))
>    endif
>    sdl_image = not_found
>  endif
> 



  reply	other threads:[~2020-09-08  7:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08  7:40 [PATCH] meson.build: tweak sdl-image error message Sergei Trofimovich
2020-09-08  7:49 ` Philippe Mathieu-Daudé [this message]
2020-09-08  8:24 ` Paolo Bonzini
2020-09-09 15:31   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89434eee-42cb-62db-32f7-9bb0dd7c31ea@redhat.com \
    --to=philmd@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkitover@gmail.com \
    --cc=slyfox@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).