Re: [PULL 04/14] vhost-user: fix shared object lookup handler logic

[Richard Henderson <richard.henderson@linaro.org>]

On 11/10/25 10:23, Albert Esteve wrote:
> On Sun, Nov 9, 2025 at 3:35 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> From: Albert Esteve <aesteve@redhat.com>
>>
>> Refactor backend_read() function and add a reply_ack variable
>> to have the option for handlers to force tweak whether they should
>> send a reply or not without depending on VHOST_USER_NEED_REPLY_MASK
>> flag.
>>
>> This fixes an issue with
>> vhost_user_backend_handle_shared_object_lookup() logic, as the
>> error path was not closing the backend channel correctly. So,
>> we can remove the reply call from within the handler, make
>> sure it returns early on errors as other handlers do and
>> set the reply_ack variable on backend_read() to true to ensure
>> that it will send a response, thus keeping the original intent.
> 
> Hey Michal,
> 
> This patch was
> Based-on: <20251016143827.1850397-1-aesteve@redhat.com>
> … for main.
> 
> As this was the first time I did this based-on thingy, I am just
> making sure that the other patch was not missed.
> If this PULL is only targeting stable, then it's ok as is.

This PR is targeting master, and "vhost-user: Add SHMEM_MAP/UNMAP requests" is not present.

Albert, thanks for noticing.
Michael, I'll hold off on applying this PR for the moment.


r~