From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Joel Stanley" <joel@jms.id.au>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE
Date: Wed, 24 Mar 2021 10:05:42 +0100 [thread overview]
Message-ID: <89880af3-bc5e-040c-8065-439b3477c8fb@redhat.com> (raw)
In-Reply-To: <ddc26232-ec90-9c50-1c50-e99a9b5ca6e2@kaod.org>
On 24/03/2021 08.21, Cédric Le Goater wrote:
> On 3/24/21 8:09 AM, Joel Stanley wrote:
>> This adds a test for the Aspeed Hash and Crypto (HACE) engine. It tests
>> the currently implemented behavior of the hash functionality.
>>
>> The tests are similar, but are cut/pasted instead of broken out into a
>> common function so the assert machinery produces useful output when a
>> test fails.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
> Thomas,
>
> Can we keep your Acked-by ?
Yes:
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-03-24 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:09 [PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine Joel Stanley
2021-03-24 7:09 ` [PATCH v4 1/3] hw: Model ASPEED's Hash and Crypto Engine Joel Stanley
2021-03-24 7:26 ` Cédric Le Goater
2021-03-24 9:46 ` Philippe Mathieu-Daudé
2021-03-24 7:09 ` [PATCH v4 2/3] aspeed: Integrate HACE Joel Stanley
2021-03-24 7:21 ` Cédric Le Goater
2021-03-24 9:47 ` Philippe Mathieu-Daudé
2021-03-24 7:09 ` [PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE Joel Stanley
2021-03-24 7:21 ` Cédric Le Goater
2021-03-24 9:05 ` Thomas Huth [this message]
2021-03-24 7:30 ` [PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89880af3-bc5e-040c-8065-439b3477c8fb@redhat.com \
--to=thuth@redhat.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=f4bug@amsat.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).