From: Maxim Levitsky <mlevitsk@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
"Markus Armbruster" <armbru@redhat.com>,
"Max Reitz" <mreitz@redhat.com>, "John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH v8 11/14] block/core: add generic infrastructure for x-blockdev-amend qmp command
Date: Wed, 08 Jul 2020 19:11:07 +0300 [thread overview]
Message-ID: <8995e3e3eac07900eefc3d1df4b75b06df292e34.camel@redhat.com> (raw)
In-Reply-To: <20200708142312.beexccqrg2n4ma6m@sirius.home.kraxel.org>
On Wed, 2020-07-08 at 16:23 +0200, Gerd Hoffmann wrote:
> On Wed, Jul 08, 2020 at 04:06:45PM +0300, Maxim Levitsky wrote:
> > On Wed, 2020-07-08 at 14:33 +0200, Gerd Hoffmann wrote:
> > > On Mon, Jun 08, 2020 at 12:40:27PM +0300, Maxim Levitsky wrote:
> > > > blockdev-amend will be used similiar to blockdev-create
> > > > to allow on the fly changes of the structure of the format based block devices.
> > >
> > > This one breaks the build:
> > >
> > > In file included from /home/kraxel/projects/qemu/include/block/throttle-groups.h:29,
> > > from /home/kraxel/projects/qemu/include/sysemu/block-backend.h:17,
> > > from /home/kraxel/projects/qemu/qemu-img.c:46:
> > > /home/kraxel/projects/qemu/include/block/block_int.h:154:39: error: unknown type name ‘BlockdevAmendOptions’; did you mean ‘BlockdevAioOptions’?
> > > BlockdevAmendOptions *opts,
> > > ^~~~~~~~~~~~~~~~~~~~
> > > BlockdevAioOptions
> > > make: *** [/home/kraxel/projects/qemu/rules.mak:69: qemu-img.o] Error 1
> > >
> > > take care,
> > > Gerd
> > >
> >
> > Apparently I didn't add #include of qapi-types-block-core.h in block_int.h (I'll fix this in a patch soon),
> > but it looks like throttle-groups.h includes "qemu/throttle.h" which includes "qapi/qapi-types-block-core.h",
> > so it should be included explicitly here.
>
> Ok, scratch that.
>
> Seems this came from stale files still being around from an in-tree
> build. Dunno how that happened, usually I do out-of-tree builds
> exclusively.
>
> sorry for the extra work,
> Gerd
>
No problem!
I will send a patch to fix the include anyway though in few days.
Best regards,
Maxim levitsky
next prev parent reply other threads:[~2020-07-08 22:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:40 [PATCH v8 00/14] LUKS: encryption slot management using amend interface Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 01/14] qcrypto/core: add generic infrastructure for crypto options amendment Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 02/14] qcrypto/luks: implement encryption key management Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 03/14] block/amend: add 'force' option Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 04/14] block/amend: separate amend and create options for qemu-img Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 05/14] block/amend: refactor qcow2 amend options Maxim Levitsky
2020-06-16 13:23 ` Max Reitz
2020-06-08 9:40 ` [PATCH v8 06/14] block/crypto: rename two functions Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 07/14] block/crypto: implement the encryption key management Maxim Levitsky
2020-06-08 12:14 ` Max Reitz
2020-06-16 13:57 ` Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 08/14] block/qcow2: extend qemu-img amend interface with crypto options Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 09/14] iotests: filter few more luks specific create options Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 10/14] iotests: qemu-img tests for luks key management Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 11/14] block/core: add generic infrastructure for x-blockdev-amend qmp command Maxim Levitsky
2020-07-08 12:33 ` Gerd Hoffmann
2020-07-08 13:06 ` Maxim Levitsky
2020-07-08 13:47 ` Gerd Hoffmann
2020-07-08 14:23 ` Gerd Hoffmann
2020-07-08 16:11 ` Maxim Levitsky [this message]
2020-06-08 9:40 ` [PATCH v8 12/14] block/crypto: implement blockdev-amend Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 13/14] block/qcow2: " Maxim Levitsky
2020-06-08 9:40 ` [PATCH v8 14/14] iotests: add tests for blockdev-amend Maxim Levitsky
2020-06-08 11:54 ` [PATCH v8 00/14] LUKS: encryption slot management using amend interface no-reply
2020-06-08 12:15 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8995e3e3eac07900eefc3d1df4b75b06df292e34.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).