From: Jose Ricardo Ziviani <jziviani@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] vga: don't abort when adding a duplicate isa-vga device
Date: Mon, 16 Aug 2021 09:34:11 -0300 [thread overview]
Message-ID: <89988201-e41c-89df-686e-243c34cc7d0f@suse.de> (raw)
In-Reply-To: <20210816050555.k63uuhqhbloarcj2@sirius.home.kraxel.org>
Hello Thomas and Gerd,
Thank you for reviewing it. Sending a v2 soon.
Thank you very much!
On 16/08/2021 02:05, Gerd Hoffmann wrote:
> Hi,
>
>>> + if (qemu_ram_block_by_name("vga.vram")) {
>>> + error_report("vga.vram is already registered, ignoring this device");
>>> + return;
>>> + }
>> I think we should not ignore the error, but rather turn this into a proper
>> error (instead of aborting).
> Yes. Silently fixing up things automatically tends to be worse long-term.
>
> take care,
> Gerd
>
next prev parent reply other threads:[~2021-08-16 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 23:36 [PATCH] vga: don't abort when adding a duplicate isa-vga device Jose R. Ziviani
2021-08-14 6:52 ` Thomas Huth
2021-08-16 5:05 ` Gerd Hoffmann
2021-08-16 12:34 ` Jose Ricardo Ziviani [this message]
2021-08-24 5:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89988201-e41c-89df-686e-243c34cc7d0f@suse.de \
--to=jziviani@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).