Re: [Qemu-devel] [PATCH v5 0/9] Enable passing pre-opened chardev socket FD

[Eric Blake <eblake@redhat.com>]

On 03/12/2018 07:49 AM, Daniel P. Berrangé wrote:
> An update of:
> 
>    v1: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04618.html
>    v2: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04706.html
>    v3: https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg04892.html
>    v4: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg00950.html
> 
> This enables fixing a long standing problem that libvirt has with
> starting up QEMU. It has to busy-wait retrying connect() on the QMP
> monitor socket until QEMU finally creates & listens on it, but at same
> time must be careful to not wait forever if QEMU exits.
> 
> With this patch series, libvirt can simply pass in a pre-opened UNIX domain
> socket file descriptor, which it can immediately connect to with no busy-wait.
> 
> NB, this will generate one expected failure with patchew / checkpatch.pl
> 
>    ERROR: consider using qemu_strtol in preference to strtol
>    #729: FILE: util/cutils.c:338:
>    +    lresult = strtol(nptr, &ep, base);
> 
>    ERROR: consider using qemu_strtol in preference to strtol
>    #779: FILE: util/cutils.c:388:
>    +    lresult = strtol(nptr, &ep, base);
> 
> This is ok to ignore, because the patch in question is introducing new
> qemu_strtoXXX wrappers
> 
> Changed in v5:
> 
>    - Docs typo (Eric)
>    - Fix errno setting in int parsing code (Eric)

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org