From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: cota@braap.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH] tests: replace rem = sleep(time) with g_timer
Date: Fri, 11 Jan 2019 15:43:30 +0100 [thread overview]
Message-ID: <89afa3af-940d-7f3b-ee7c-25027bfd18f5@redhat.com> (raw)
In-Reply-To: <20190111143815.26107-1-alex.bennee@linaro.org>
On 11/01/19 15:38, Alex Bennée wrote:
> Relying on sleep to always return having slept isn't safe as a signal
> may have occurred. If signals are constantly incoming the program will
> never reach it's termination condition. This is believed to be the
> mechanism causing time outs for qht-test in Travis.
>
> Instead we use a g_timer to determine if the duration of the test has
> passed and sleep for a second at a time. This may bias benchmark
> results for short runs.
Why not g_usleep? It already does a while loop around nanosleep (which
returns the remaining time in the wait, like select but unlike sleep and
poll).
Thanks,
Paolo
next prev parent reply other threads:[~2019-01-11 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 14:38 [Qemu-devel] [RFC PATCH] tests: replace rem = sleep(time) with g_timer Alex Bennée
2019-01-11 14:43 ` Paolo Bonzini [this message]
2019-01-11 15:28 ` Alex Bennée
2019-01-11 15:41 ` Paolo Bonzini
2019-01-11 16:05 ` Alex Bennée
2019-01-11 16:06 ` Alex Bennée
2019-01-11 19:05 ` Eduardo Habkost
2019-01-11 18:32 ` Greg Kurz
2019-01-11 19:25 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89afa3af-940d-7f3b-ee7c-25027bfd18f5@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).