qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] s390x: Fix QEMU abort by selecting S390_FLIC_KVM
Date: Tue, 11 Jul 2023 16:50:25 +0200	[thread overview]
Message-ID: <89d0f254-d27c-518d-180d-d4adae770cd7@linaro.org> (raw)
In-Reply-To: <20230711143426.708978-1-clg@redhat.com>

On 11/7/23 16:34, Cédric Le Goater wrote:
> If QEMU is built with --without-default-devices, the s390-flic-kvm
> device is missing and QEMU aborts when started with the KVM accelerator.
> Make sure it's available by selecting S390_FLIC_KVM in Kconfig.
> 
> Consequently, this also fixes an abort in tests/qtest/migration-test.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/intc/Kconfig  | 1 -
>   hw/s390x/Kconfig | 1 +
>   2 files changed, 1 insertion(+), 1 deletion(-)


> diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig
> index 5e7d8a2bae8b..0dad184e06d2 100644
> --- a/hw/s390x/Kconfig
> +++ b/hw/s390x/Kconfig
> @@ -7,6 +7,7 @@ config S390_CCW_VIRTIO
>       imply WDT_DIAG288
>       select PCI
>       select S390_FLIC
> +    select S390_FLIC_KVM

         select S390_FLIC_KVM if KVM?

>       select SCLPCONSOLE
>       select VIRTIO_CCW
>       select MSI_NONBROKEN



      reply	other threads:[~2023-07-11 14:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11 14:34 [PATCH] s390x: Fix QEMU abort by selecting S390_FLIC_KVM Cédric Le Goater
2023-07-11 14:50 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89d0f254-d27c-518d-180d-d4adae770cd7@linaro.org \
    --to=philmd@linaro.org \
    --cc=clg@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).