From: Thomas Huth <thuth@redhat.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] audio: remove QEMU_AUDIO_* and -audio-help support
Date: Tue, 5 Sep 2023 13:41:56 +0200 [thread overview]
Message-ID: <89e56b56-44d8-4d87-384d-bb12d4fbc9ee@redhat.com> (raw)
In-Reply-To: <4c044b4c-87cd-c81b-6d4e-e7c8b8622098@redhat.com>
On 05/09/2023 12.55, Paolo Bonzini wrote:
> On 9/5/23 12:39, Thomas Huth wrote:
>>>
>>> + dolog("Device %s: audiodev default parameter is deprecated,
>>> please "
>>> + "specify audiodev=%s\n", name,
>>> + QTAILQ_FIRST(&audio_states)->dev->id);
>>
>> You said that you removed the default handling ... so this log message
>> looks suspicious ... is this code block still required?
>
> I was referring to the ".can_be_default" argument, maybe I should change
> "default audio backend" to "default audio driver" in the commit message?
No, I think it's fine. Thanks for the clarification!
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2023-09-05 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 10:19 [PATCH] audio: remove QEMU_AUDIO_* and -audio-help support Paolo Bonzini
2023-09-05 10:39 ` Thomas Huth
2023-09-05 10:55 ` Paolo Bonzini
2023-09-05 11:41 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e56b56-44d8-4d87-384d-bb12d4fbc9ee@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).