Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function

[Alex Bligh <alex@alex.org.uk>]

--On 11 September 2013 16:48:41 +0100 "Daniel P. Berrange" 
<berrange@redhat.com> wrote:

> We know the precise list of valid modules when building QEMU,
> so IMHO, this should just explicitly load each known module
> name, and *not* readdir. Also it should do something along the
> lines suggested their of poisoning exported symbols with a
> build hash to guarantee the modules loaded match the original
> binary and that the symbols change on every rebuild.
>
> The latter is important even ignoring the 3rd party module
> question, since it ensures developers/users don't accidently
> run with mis-match QEMU and module builds, which could lead
> to some very hard to diagnose bugs / behaviour.

+1

Though in the interest of not having to recompile everything
for one minor change a .c file in qemu whilst developing,
perhaps we could just hash exported symbols and include that
hash, rather than ensuring the symbols change on (literally)
every rebuild. Else every dev will build with modules turned
off!

-- 
Alex Bligh