qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <huth@tuxfamily.org>,
	Willian Rampazzo <wrampazz@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern
Date: Thu, 19 Sep 2019 18:19:40 +0200	[thread overview]
Message-ID: <8a087ca1-cdae-20ee-d939-a47be4f25235@redhat.com> (raw)
In-Reply-To: <20190919161400.26399-1-crosa@redhat.com>

Cc'ing Thomas

On 9/19/19 6:14 PM, Cleber Rosa wrote:
> Instead of looking for a specific error, let's relax the pattern
> because different errors have been seen (I'm consistenly getting 52)
> and the real goal of this test is to validate the framebuffer
> operation, and not to reproduce one specific error.

This might be because I wrote this test before Thomas added the serial
controller (commit b17bed5b1727e3aa9e37fc8e8c3222130ceab22f).

> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/acceptance/machine_m68k_nextcube.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/machine_m68k_nextcube.py b/tests/acceptance/machine_m68k_nextcube.py
> index e09cab9f20..fcd2c58ee7 100644
> --- a/tests/acceptance/machine_m68k_nextcube.py
> +++ b/tests/acceptance/machine_m68k_nextcube.py
> @@ -116,6 +116,6 @@ class NextCubeMachine(Test):
>              if len(line):
>                  console_logger.debug(line)
>          self.assertIn('Testing the FPU, SCC', text)
> -        self.assertIn('System test failed. Error code 51', text)
> +        self.assertIn('System test failed. Error code', text)
>          self.assertIn('Boot command', text)
>          self.assertIn('Next>', text)
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  reply	other threads:[~2019-09-19 16:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 16:14 [PATCH] Acceptance test machine_m68k_nextcube.py: relax the error code pattern Cleber Rosa
2019-09-19 16:19 ` Philippe Mathieu-Daudé [this message]
2019-09-19 19:26   ` Thomas Huth
2019-09-19 22:20     ` Cleber Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a087ca1-cdae-20ee-d939-a47be4f25235@redhat.com \
    --to=philmd@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=huth@tuxfamily.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).