qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Anand J <anand.indukala@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] clean-up: removed duplicate #includes
Date: Thu, 20 Oct 2016 11:11:03 +0200	[thread overview]
Message-ID: <8a08e858-c3cf-020a-af58-d4882ff43d54@redhat.com> (raw)
In-Reply-To: <CANDALv=KvM2W1ww57-mbo8-JyNvkyYRQPos2HXQob6Gccu-vXw@mail.gmail.com>

On 18.10.2016 14:39, Anand J wrote:
> 
> 
> On Tue, Oct 18, 2016 at 4:03 PM, Anand J <anand.indukala@gmail.com
> <mailto:anand.indukala@gmail.com>> wrote:
> 
>     Some files contain multiple #includes of the same header file.
>     Removed most of those unnecessary duplicate entries using
>     scripts/clean-includes.
> 
>     Signed-off-by: Anand J <anand.indukala@gmail.com
>     <mailto:anand.indukala@gmail.com>>
>     ---
>      accel.c                             | 1 -
>      cputlb.c                            | 1 -
>      gdbstub.c                           | 1 -
>      hw/i386/acpi-build.c                | 1 -
>      hw/microblaze/boot.c                | 1 -
>      hw/mips/mips_malta.c                | 1 -
>      hw/nvram/fw_cfg.c                   | 1 -
>      hw/pci-bridge/pci_expander_bridge.c | 1 -
>      hw/ppc/ppc405_boards.c              | 1 -
>      hw/ppc/spapr.c                      | 1 -
>      hw/timer/grlib_gptimer.c            | 1 -
>      hw/tpm/tpm_tis.c                    | 1 -
>      hw/unicore32/puv3.c                 | 1 -
>      hw/usb/dev-mtp.c                    | 1 -
>      include/hw/i386/pc.h                | 1 -
>      monitor.c                           | 2 --
>      qemu-io-cmds.c                      | 1 -
>      qmp.c                               | 1 -
>      target-i386/machine.c               | 3 ---
>      target-mips/machine.c               | 1 -
>      target-ppc/machine.c                | 1 -
>      target-ppc/mem_helper.c             | 1 -
>      target-sparc/machine.c              | 3 ---
>      target-xtensa/translate.c           | 1 -
>      tests/crypto-tls-x509-helpers.h     | 3 ---
>      tests/vhost-user-test.c             | 2 --
>      util/oslib-posix.c                  | 1 -
>      vl.c                                | 1 -
>      28 files changed, 36 deletions(-)

This patch looks also fine to me now - but again, please no HTML
e-mails. Could you please resend as plain text mail with CC: to
qemu-trivial@nongnu.org ?

 Thanks,
  Thomas

  reply	other threads:[~2016-10-20  9:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 10:33 [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check Anand J
2016-10-18 10:33 ` [Qemu-devel] [PATCH 2/2] clean-up: removed duplicate #includes Anand J
2016-10-18 12:39   ` Anand J
2016-10-20  9:11     ` Thomas Huth [this message]
2016-10-20  9:56       ` Anand J
2016-10-18 12:38 ` [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check Anand J
2016-10-20  9:08   ` Thomas Huth
2016-10-20  9:56     ` Anand J
  -- strict thread matches above, loose matches on Subject: below --
2016-10-20  9:52 Anand J
2016-10-20  9:52 ` [Qemu-devel] [PATCH 2/2] clean-up: removed duplicate #includes Anand J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a08e858-c3cf-020a-af58-d4882ff43d54@redhat.com \
    --to=thuth@redhat.com \
    --cc=anand.indukala@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).