From: Richard Henderson <rth@twiddle.net>
To: KONRAD Frederic <konrad@adacore.com>, qemu-devel@nongnu.org
Cc: mark.cave-ayland@ilande.co.uk, frederic.konrad@adacore.com
Subject: Re: [Qemu-devel] [PATCH] sparc: fix leon3 casa instruction when MMU is disabled
Date: Fri, 2 Mar 2018 11:04:17 -0800 [thread overview]
Message-ID: <8a0c9302-3c3a-6d2f-064c-231adc126dbd@twiddle.net> (raw)
In-Reply-To: <1519984765-15748-1-git-send-email-konrad@adacore.com>
On 03/02/2018 01:59 AM, KONRAD Frederic wrote:
> From: KONRAD Frederic <frederic.konrad@adacore.com>
>
> Since the commit af7a06bac7d3abb2da48ef3277d2a415772d2ae8:
> `casa [..](10), .., ..` (and probably others alternate space instructions)
> triggers a data access exception when the MMU is disabled.
>
> When we enter get_asi(...) dc->mem_idx is set to MMU_PHYS_IDX when the MMU
> is disabled. Just keep mem_idx unchanged in this case so we passthrough the
> MMU when it is disabled.
>
> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
> ---
>
> Notes:
> Changes RFC -> V1:
> * emit the instruction with MMU_PHYS_IDX instead of checking that the MMU
> is enabled in get_physical_address(..)
>
> target/sparc/translate.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-03-02 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 9:59 [Qemu-devel] [PATCH] sparc: fix leon3 casa instruction when MMU is disabled KONRAD Frederic
2018-03-02 19:04 ` Richard Henderson [this message]
2018-03-05 9:14 ` KONRAD Frederic
2018-03-05 21:56 ` Mark Cave-Ayland
2018-03-06 9:03 ` Richard Henderson
2018-03-07 18:49 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a0c9302-3c3a-6d2f-064c-231adc126dbd@twiddle.net \
--to=rth@twiddle.net \
--cc=frederic.konrad@adacore.com \
--cc=konrad@adacore.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).