* [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency
@ 2017-09-11 21:01 Philippe Mathieu-Daudé
2017-09-11 21:57 ` Marc-André Lureau
2017-09-12 7:47 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-11 21:01 UTC (permalink / raw)
To: Michael Roth, Peter Maydell, Tomáš Golembiovský
Cc: Philippe Mathieu-Daudé, qemu-devel, Daniel P . Berrange,
Paolo Bonzini, Eric Blake, Marc-André Lureau
this fixes running 'make check-unit' without running 'make all' beforehand:
$ make check-unit
...
GTESTER tests/test-qga
**
ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): Failed to execute child process "/build/qemu/qemu-ga" (No such file or directory) (g-exec-error-quark, 8)
make: *** [check-tests/test-qga] Error 1
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
occured trying to split Travis jobs to run more/faster
tests/Makefile.include | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index fae5715e9c..59e027f6ea 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -832,7 +832,8 @@ endif
qtest-obj-y = tests/libqtest.o $(test-util-obj-y)
$(check-qtest-y): $(qtest-obj-y)
-tests/test-qga: tests/test-qga.o $(qtest-obj-y)
+tests/test-qga$(EXESUF): qemu-ga$(EXESUF)
+tests/test-qga$(EXESUF): tests/test-qga.o $(qtest-obj-y)
SPEED = quick
GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency
2017-09-11 21:01 [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency Philippe Mathieu-Daudé
@ 2017-09-11 21:57 ` Marc-André Lureau
2017-09-12 7:47 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2017-09-11 21:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Michael Roth, Peter Maydell,
Tomáš Golembiovský
Cc: qemu-devel, Paolo Bonzini
On Mon, Sep 11, 2017 at 11:02 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> this fixes running 'make check-unit' without running 'make all' beforehand:
>
> $ make check-unit
> ...
> GTESTER tests/test-qga
> **
> ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL):
> Failed to execute child process "/build/qemu/qemu-ga" (No such file or
> directory) (g-exec-error-quark, 8)
> make: *** [check-tests/test-qga] Error 1
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> occured trying to split Travis jobs to run more/faster
>
> tests/Makefile.include | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index fae5715e9c..59e027f6ea 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -832,7 +832,8 @@ endif
> qtest-obj-y = tests/libqtest.o $(test-util-obj-y)
> $(check-qtest-y): $(qtest-obj-y)
>
> -tests/test-qga: tests/test-qga.o $(qtest-obj-y)
> +tests/test-qga$(EXESUF): qemu-ga$(EXESUF)
> +tests/test-qga$(EXESUF): tests/test-qga.o $(qtest-obj-y)
>
> SPEED = quick
> GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
> --
> 2.14.1
>
>
> --
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency
2017-09-11 21:01 [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency Philippe Mathieu-Daudé
2017-09-11 21:57 ` Marc-André Lureau
@ 2017-09-12 7:47 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-09-12 7:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Michael Roth, Peter Maydell,
Tomáš Golembiovský
Cc: qemu-devel, Daniel P . Berrange, Eric Blake,
Marc-André Lureau
On 11/09/2017 23:01, Philippe Mathieu-Daudé wrote:
> this fixes running 'make check-unit' without running 'make all' beforehand:
>
> $ make check-unit
> ...
> GTESTER tests/test-qga
> **
> ERROR:tests/test-qga.c:73:fixture_setup: assertion failed (error == NULL): Failed to execute child process "/build/qemu/qemu-ga" (No such file or directory) (g-exec-error-quark, 8)
Queued, thanks.
Paolo
> make: *** [check-tests/test-qga] Error 1
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> occured trying to split Travis jobs to run more/faster
>
> tests/Makefile.include | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index fae5715e9c..59e027f6ea 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -832,7 +832,8 @@ endif
> qtest-obj-y = tests/libqtest.o $(test-util-obj-y)
> $(check-qtest-y): $(qtest-obj-y)
>
> -tests/test-qga: tests/test-qga.o $(qtest-obj-y)
> +tests/test-qga$(EXESUF): qemu-ga$(EXESUF)
> +tests/test-qga$(EXESUF): tests/test-qga.o $(qtest-obj-y)
>
> SPEED = quick
> GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-12 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-11 21:01 [Qemu-devel] [PATCH] test-qga: add missing qemu-ga tool dependency Philippe Mathieu-Daudé
2017-09-11 21:57 ` Marc-André Lureau
2017-09-12 7:47 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).