From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89184C433E0 for ; Wed, 5 Aug 2020 13:58:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53DFC2312D for ; Wed, 5 Aug 2020 13:58:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eM9pvTym" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53DFC2312D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3Jvm-0006fY-Ik for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 09:58:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3JvC-0006G3-Uj for qemu-devel@nongnu.org; Wed, 05 Aug 2020 09:57:34 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:20733 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3Jv9-0005vd-Oh for qemu-devel@nongnu.org; Wed, 05 Aug 2020 09:57:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596635850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JwrbFjn/yS5cg3dxlld0kDagdXyDVhNOb3QKKmTRTZ0=; b=eM9pvTymlhJT7YCjMasvwcg2eT00NtdagZjfPsY2TECRF0gJ9yK5HQutaUEe2DBNimDMrt i4E5l7UJZkV3MRgiSltRDrSdtUIa4sygTVksBW4p34kv2ysmBRjzqY5E/Qn+ZQMpNxlXRK Jsqo9VZBU0cJUxxlNpl+8W2Q6RMYkE0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-EtZGgwVgN3aZikkRFeVl3w-1; Wed, 05 Aug 2020 09:57:29 -0400 X-MC-Unique: EtZGgwVgN3aZikkRFeVl3w-1 Received: by mail-wr1-f71.google.com with SMTP id b13so10887997wrq.19 for ; Wed, 05 Aug 2020 06:57:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=JwrbFjn/yS5cg3dxlld0kDagdXyDVhNOb3QKKmTRTZ0=; b=cDsU3a5q/3pOPqy9ODdOjW+j4Xn4AvEi0vKjayURcd8CRZm8GgLBbTe+xQZy/FAQKi iBlwFNUw5NnjN1kakiDVJZzIQYZ9QUmt/AyZMsnYjOHolgF0zwNBjjZ4blu3Q4MgTDyD mILJuk2v98kxozS2azjIC8gaAfXV30kBlCIB7A3vb+oSm1rkQm/w2D4TFsFDPTB9N4+n WaDbyIJKv+Fx2I+pkjLmz2wDcFIVYsXfe2UU15oSBp6FyQke8I9jxe2ss5a8dTYr8vZg yYnF59JlB5I1tR7HrrazD7I4S0XjZ9mHEuz396hi2JYyxrQfiJUwAR8hOiJqrqn90IQY tvPQ== X-Gm-Message-State: AOAM530oAeHFCADL4ayLKwJLjcjRPda3tU/z+P3iOP+9CZs4JC+rtR1j RjSHVZyK1EJW/TpvQvbLtVTFdrIZyZ+5NaJXUSKxBCp5IeQXKvnRei6wqUY+z63qnBBPzMtAvua OYNG6r9+l7qmul1A= X-Received: by 2002:a7b:cc8e:: with SMTP id p14mr3352993wma.111.1596635847925; Wed, 05 Aug 2020 06:57:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6GvLbf+/UZWSx4zIXTFJn+0ieD8C2BU+YIVe2pWbdwN3Dp7CA287nIVBJeoUSpFLQ+24AaA== X-Received: by 2002:a7b:cc8e:: with SMTP id p14mr3352973wma.111.1596635847710; Wed, 05 Aug 2020 06:57:27 -0700 (PDT) Received: from [192.168.1.36] (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id z11sm2671741wrw.93.2020.08.05.06.57.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 06:57:27 -0700 (PDT) Subject: Re: [PATCH] softmmu: Add missing trace-events file To: Markus Armbruster , Thomas Huth References: <20200805130221.24487-1-philmd@redhat.com> <87wo2dmde8.fsf@dusky.pond.sub.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <8a260e67-2bae-17d7-d34c-239df1c5eb5c@redhat.com> Date: Wed, 5 Aug 2020 15:57:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <87wo2dmde8.fsf@dusky.pond.sub.org> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 04:10:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , David Hildenbrand , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Claudio Fontana , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/5/20 3:27 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Commit c7f419f584 moved softmmu-only files out of the root >> directory, but forgot to move the trace events, which should >> no longer be generated to "trace-root.h". Fix that by adding >> softmmu/trace-events. > > Dang! I'd like to have this in 5.1 if at all possible. > [...] > > scripts/cleanup-trace-events.pl finds these (and corrects them in-place, > which is not what we want here). It finds a few more. I'll look more > closely and report back. Congratulation, you just found the first job you'll add to our GitLab CI =)