From: John Snow <jsnow@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Peter Krempa" <pkrempa@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v4 0/2] Gitlab: Add issue templates
Date: Tue, 22 Jun 2021 09:22:04 -0400 [thread overview]
Message-ID: <8a330da7-3d8e-53d2-46a5-7c2542fd5872@redhat.com> (raw)
In-Reply-To: <8e156869-f17f-a2f5-b3e0-bb188a50c919@redhat.com>
Alex, do you want to stage this one with your test pulls? (You could
amend patch #2 with your suggestion when you do?)
On 6/15/21 4:26 AM, Thomas Huth wrote:
> On 15/06/2021 02.03, John Snow wrote:
>> On 6/7/21 11:31 AM, John Snow wrote:
>>> Add "Bug" and "Feature Request" templates to the Gitlab interface to
>>> help improve the quality of newly reported issues.
>>>
>>> To see what this looks like, I've temporarily allowed my Gitlab fork to
>>> diverge with these files merged. See my fork's "new issue" page to see
>>> it in action: https://gitlab.com/jsnow/qemu/-/issues/new?issue
>>>
>>> (It's outdated a bit for V4, but you get the idea.)
>>>
>>> These patches do not add a "default" template, the user still has to
>>> select one from the list. I recommend that someone with permissions
>>> updates the default template:
>>>
>>> 1. https://gitlab.com/qemu-project/qemu/edit
>>> 2. ctrl+f "Default description template for issues"
>>> 3. Update the default to the (suggested) below:
>>>
>>> ```
>>> <!-- Select "Type: Issue" and choose one of the Description templates
>>> above. -->
>>> ```
>>>
>>> We can use this cover letter to discuss/review the wording on that
>>> default template which exists outside of repository data.
>>>
>>> V4:
>>> - Change the "build on master" to be more of a nudge than a mandate,
>>> with improved instructions (stefanha, danpb)
>>>
>>> V3:
>>> - Add pointer to https://www.qemu.org/download/#source
>>> - Add pointer to https://www.qemu.org/contribute/security-process/
>>> - Remove blurb covering tracing instructions.
>>>
>>> V2:
>>> - Updated both templates based on feedback from Peter, Daniel, and
>>> Thomas.
>>>
>>> John Snow (2):
>>> GitLab: Add "Bug" issue reporting template
>>> GitLab: Add "Feature Request" issue template.
>>>
>>> .gitlab/issue_templates/bug.md | 64 ++++++++++++++++++++++
>>> .gitlab/issue_templates/feature_request.md | 32 +++++++++++
>>> 2 files changed, 96 insertions(+)
>>> create mode 100644 .gitlab/issue_templates/bug.md
>>> create mode 100644 .gitlab/issue_templates/feature_request.md
>>>
>>
>> Gentle ping. I do not know whose jurisdiction this falls under.
>
> I assume this should be merged by someone who has maintainer rights in
> the qemu-project on gitlab (for also updating the default template)?
>
> Thomas
>
>
next prev parent reply other threads:[~2021-06-22 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:31 [PATCH v4 0/2] Gitlab: Add issue templates John Snow
2021-06-07 15:31 ` [PATCH v4 1/2] GitLab: Add "Bug" issue reporting template John Snow
2021-06-08 13:57 ` Alex Bennée
2021-06-07 15:31 ` [PATCH v4 2/2] GitLab: Add "Feature Request" issue template John Snow
2021-06-08 13:59 ` Alex Bennée
2021-06-08 14:25 ` John Snow
2021-06-08 8:33 ` [PATCH v4 0/2] Gitlab: Add issue templates Stefan Hajnoczi
2021-06-15 0:03 ` John Snow
2021-06-15 8:26 ` Thomas Huth
2021-06-22 13:22 ` John Snow [this message]
2021-06-23 9:25 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a330da7-3d8e-53d2-46a5-7c2542fd5872@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).