From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Derek Su <dereksu@qnap.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v11 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit
Date: Tue, 14 Jul 2020 14:26:44 +0200 [thread overview]
Message-ID: <8a40b4a3-86d2-261f-25b5-75d9b9f5f54b@redhat.com> (raw)
In-Reply-To: <6476caaa73216bd05b7bb2d504a20415e1665176.1594396418.git.berto@igalia.com>
[-- Attachment #1.1: Type: text/plain, Size: 1777 bytes --]
On 10.07.20 18:13, Alberto Garcia wrote:
> Now that the implementation of subclusters is complete we can finally
> add the necessary options to create and read images with this feature,
> which we call "extended L2 entries".
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
> qapi/block-core.json | 7 +++
> block/qcow2.h | 8 ++-
> include/block/block_int.h | 1 +
> block/qcow2.c | 66 ++++++++++++++++++--
> tests/qemu-iotests/031.out | 8 +--
> tests/qemu-iotests/036.out | 4 +-
> tests/qemu-iotests/049.out | 102 +++++++++++++++----------------
> tests/qemu-iotests/060.out | 1 +
> tests/qemu-iotests/061.out | 20 +++---
> tests/qemu-iotests/065 | 12 ++--
> tests/qemu-iotests/082.out | 39 +++++++++---
> tests/qemu-iotests/085.out | 38 ++++++------
> tests/qemu-iotests/144.out | 4 +-
> tests/qemu-iotests/182.out | 2 +-
> tests/qemu-iotests/185.out | 8 +--
> tests/qemu-iotests/198 | 2 +
Oh, yes. 198, not 191. Sorry.
> tests/qemu-iotests/206.out | 4 ++
> tests/qemu-iotests/242.out | 5 ++
> tests/qemu-iotests/255.out | 8 +--
> tests/qemu-iotests/274.out | 49 ++++++++-------
> tests/qemu-iotests/280.out | 2 +-
> tests/qemu-iotests/291.out | 2 +
> tests/qemu-iotests/common.filter | 1 +
> 23 files changed, 253 insertions(+), 140 deletions(-)
Looks good. Some of the patches in Kevin’s block branch will inevitably
require some more churn, but all of it looks obvious to resolve.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-14 12:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 16:12 [PATCH v11 00/34] Add subcluster allocation to qcow2 Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 01/34] qcow2: Make Qcow2AioTask store the full host offset Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 02/34] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 03/34] qcow2: Add calculate_l2_meta() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 04/34] qcow2: Split cluster_needs_cow() out of count_cow_clusters() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 05/34] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 06/34] qcow2: Add get_l2_entry() and set_l2_entry() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 07/34] qcow2: Document the Extended L2 Entries feature Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 08/34] qcow2: Add dummy has_subclusters() function Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 09/34] qcow2: Add subcluster-related fields to BDRVQcow2State Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 10/34] qcow2: Add offset_to_sc_index() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 11/34] qcow2: Add offset_into_subcluster() and size_to_subclusters() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 12/34] qcow2: Add l2_entry_size() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 13/34] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 14/34] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 15/34] qcow2: Add qcow2_get_subcluster_range_type() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 16/34] qcow2: Add qcow2_cluster_is_allocated() Alberto Garcia
2020-07-10 16:12 ` [PATCH v11 17/34] qcow2: Add cluster type parameter to qcow2_get_host_offset() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 18/34] qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_* Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 19/34] qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 20/34] qcow2: Add subcluster support to calculate_l2_meta() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 21/34] qcow2: Add subcluster support to qcow2_get_host_offset() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 22/34] qcow2: Add subcluster support to zero_in_l2_slice() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 23/34] qcow2: Add subcluster support to discard_in_l2_slice() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 24/34] qcow2: Add subcluster support to check_refcounts_l2() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 25/34] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 26/34] qcow2: Clear the L2 bitmap when allocating a compressed cluster Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 27/34] qcow2: Add subcluster support to handle_alloc_space() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 28/34] qcow2: Add subcluster support to qcow2_co_pwrite_zeroes() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 29/34] qcow2: Add subcluster support to qcow2_measure() Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 30/34] qcow2: Add prealloc field to QCowL2Meta Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit Alberto Garcia
2020-07-14 12:26 ` Max Reitz [this message]
2020-07-10 16:13 ` [PATCH v11 32/34] qcow2: Allow preallocation and backing files if extended_l2 is set Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 33/34] qcow2: Assert that expand_zero_clusters_in_l1() does not support subclusters Alberto Garcia
2020-07-10 16:13 ` [PATCH v11 34/34] iotests: Add tests for qcow2 images with extended L2 entries Alberto Garcia
2020-07-10 16:43 ` [PATCH v11 00/34] Add subcluster allocation to qcow2 no-reply
2020-07-10 20:36 ` Alberto Garcia
2020-07-10 17:28 ` no-reply
2020-07-14 12:56 ` Max Reitz
2020-07-15 11:51 ` Alberto Garcia
2020-07-15 14:13 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a40b4a3-86d2-261f-25b5-75d9b9f5f54b@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=dereksu@qnap.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).