From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged
Date: Tue, 25 Oct 2016 11:08:27 -0500 [thread overview]
Message-ID: <8a4d830d-1db1-33e3-e2d0-c0c68e27ab5d@redhat.com> (raw)
In-Reply-To: <1477406107-10757-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
On 10/25/2016 09:35 AM, Markus Armbruster wrote:
> This is how I propose to rearrange PATCH 04+05 of Dan's "[PATCH v14
> 00/21] QAPI/QOM work for non-scalar object properties" (really v15) in
> my pull request, to make git's rename detection work. The result is
> identical except for two comments I touched up:
>
Looks sane to me. Also, looks like my R-b is already present by virtue
of the pre-split review I gave.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-10-25 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 14:35 [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged Markus Armbruster
2016-10-25 14:35 ` [Qemu-devel] [PATCH RFC 1/3] qapi: rename *qmp-*-visitor* to *qobject-*-visitor* Markus Armbruster
2016-10-25 14:35 ` [Qemu-devel] [PATCH RFC 2/3] qapi: rename QmpInputVisitor to QObjectInputVisitor Markus Armbruster
2016-10-25 14:35 ` [Qemu-devel] [PATCH RFC 3/3] qapi: rename QmpOutputVisitor to QObjectOutputVisitor Markus Armbruster
2016-10-25 15:49 ` [Qemu-devel] [PATCH RFC 0/3] Rename of the QObject visitors rearranged Daniel P. Berrange
2016-10-25 16:08 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a4d830d-1db1-33e3-e2d0-c0c68e27ab5d@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).