From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: corey@minyard.net, Bernhard Beschow <shentey@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/i2c/imx_i2c: Always set interrupt status bit if interrupt condition occurs
Date: Thu, 8 May 2025 09:14:48 +0200 [thread overview]
Message-ID: <8a5893be-7217-4c58-838c-01370db5d6bf@linaro.org> (raw)
In-Reply-To: <aBtavpDt1yfoavj7@mail.minyard.net>
On 7/5/25 15:06, Corey Minyard wrote:
> On Wed, May 07, 2025 at 02:40:40PM +0200, Bernhard Beschow wrote:
>> According to the i.MX 8M Plus reference manual, the status flag I2C_I2SR[IIF]
>> continues to be set when an interrupt condition occurs even when I2C interrupts
>> are disabled (I2C_I2CR[IIEN] is clear). However, the device model only sets the
>> flag when I2C interrupts are enabled which causes U-Boot to loop forever. Fix
>> the device model by always setting the flag and let I2C_I2CR[IIEN] guard I2C
>> interrupts only.
>>
>> Also remove the comment in the code since it merely stated the obvious and would
>> be outdated now.
>
> This looks good to me. I can give you an:
>
> Acked-by: Corey Minyard <cminyard@mvista.com>
>
> or I can take it into my tree.
I have to respin my hw-misc PR so I'll squeeze this.
Thanks!
Phil.
next prev parent reply other threads:[~2025-05-08 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 12:40 [PATCH] hw/i2c/imx_i2c: Always set interrupt status bit if interrupt condition occurs Bernhard Beschow
2025-05-07 13:06 ` Corey Minyard
2025-05-08 7:14 ` Philippe Mathieu-Daudé [this message]
2025-05-08 10:32 ` Philippe Mathieu-Daudé
2025-05-08 10:37 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a5893be-7217-4c58-838c-01370db5d6bf@linaro.org \
--to=philmd@linaro.org \
--cc=corey@minyard.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).